Adding StorSimple cmdlets #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx src/ServiceManagement/StorSimple/Commands.StorSimple/StorSimpleCmdletBase.cs
…stead of warning in case no device is registered
| { | ||
| private PSStorSimpleClient storSimpleClient; | ||
|
|
||
| internal PSStorSimpleClient StorSimpleClient |
There was a problem hiding this comment.
We don't pass PS prefix to the convenience clients as they are supposed to be generic enough for any C# code not on PowerShell
1. Make sure to update "Test" target in build.proj to include these tests 2. Copyright header 3. Add header comments 4. Fix alignment 5. Copyright header for all files in this pull request 6. The coding convention in Azure PowerShell uses string instead of String 7. Place the error messages into project Resources 8. Using’s should be before namespace 9. We don't ass PS prefix to the convenience clients as they are supposed to be generic enough for any C# code not on PowerShell 10. all messages should be in project resources 11. you could add those in Constants class: https://github.com/Azure/azure-powershell/blob/dev/src/Common/Commands.Common/Constants.cs 12. nit: remove extra line 13. no need to have private member, just use properties get/set
1. See how other projects have their version and assembly info defined 2. This csproj is used only by StorSimple projects, please merge it into the commands project 3. Move all of the business logic into a conveniece client layer 4. This logic seems duplicated, please refactor
akromm-zz
pushed a commit
to akromm-zz/azure-powershell
that referenced
this pull request
Apr 18, 2015
Add dns name public ip
DeepakRajendranMsft
pushed a commit
to DeepakRajendranMsft/azure-powershell
that referenced
this pull request
Dec 15, 2015
ionuttulai
pushed a commit
to ionuttulai/azure-powershell
that referenced
this pull request
Mar 4, 2020
Made Pester Tests for Azs.Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.