Skip to content

Bump version of Newtonsoft Json in PowerShell #7663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 30, 2018
Merged

Bump version of Newtonsoft Json in PowerShell #7663

merged 20 commits into from
Oct 30, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

@maddieclayton
Copy link
Contributor Author

Needs to be restarted once the last 5 packages are published.

@maddieclayton
Copy link
Contributor Author

@maddieclayton
Copy link
Contributor Author

All tests are passing and smoke testing was completed. PR is ready to merge once reviewed.

@maddieclayton maddieclayton changed the title [DO NOT MERGE] Testing newtonsoft bump Testing newtonsoft bump Oct 30, 2018
@maddieclayton maddieclayton changed the title Testing newtonsoft bump Bump version of Newtonsoft Json in PowerShell Oct 30, 2018
@@ -358,10 +358,10 @@
Condition="'$(SkipHelp)' == 'false'"
ContinueOnError="false"/>

<CallTarget Targets="CodeSignBinaries" Condition="'$(CodeSign)' == 'true'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making this change?

<PackageReference Include="Microsoft.Azure.Management.TrafficManager" Version="2.5.3" PrivateAssets="All" />
<PackageReference Include="Microsoft.Azure.Management.Websites" Version="2.0.1" PrivateAssets="All" />
<PackageReference Include="Microsoft.Azure.OperationalInsights" Version="0.10.0-preview" PrivateAssets="All" />
<PackageReference Include="YamlDotNet.Signed" Version="4.2.4" PrivateAssets="All" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this downgraded?

@markcowl markcowl merged commit 3de4c83 into Azure:preview Oct 30, 2018
@maddieclayton maddieclayton deleted the testing branch November 8, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants