-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix -Tags for New-AzureRmSqlDatabaseCopy #6049 #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
@jaredmoo Can you take a look at this fix? |
@azuresdkci Add to whitelist |
jaredmoo
previously approved these changes
Oct 15, 2018
@maboja-msft fyi |
MiYanni
suggested changes
Oct 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update the ChangeLog.md for Sql (add a message under Current Release header)
- Is there an issue filed for this fix? If so, I just want to make sure to close it when we merge this PR.
Issue is here: #6049 |
@dalibormesaric Can you sign the CLA above? |
maddieclayton
approved these changes
Oct 18, 2018
jaredmoo
approved these changes
Oct 18, 2018
MiYanni
approved these changes
Oct 18, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes assigning tags when running New-AzureRmSqlDatabaseCopy command.
I would need some guidance if there is anything else that needs to be changed (change logs etc.)
Checklist
CONTRIBUTING.md
platyPS
module