Fix Get-AzureRmVM paging with ResourceGroupName #7292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbera
force-pushed
the
fix-vm-paging-by-rg
branch
from
20b0118 to
b768376
Compare
|
@hyonholee Hey Hyonho, would you mind reviewing this PR when you get the chance? |
jabbera
force-pushed
the
fix-vm-paging-by-rg
branch
from
b768376 to
a0a11d6
Compare
|
Sorted the CI build. |
|
Sorry, folks, this appears to be a regression from the server side. We just enabled paging for the GET VMs in Resource Group query but it was not done properly with an api-version check. We'll correct this in the next few days. The client-side fix will probably also be needed, but deferring to Hyonho & co. to figure out exactly what & where. |
hyonholee
reviewed
Sep 24, 2018
|
|
||
| if (!string.IsNullOrEmpty(vmListResult.Body.NextPageLink)) | ||
| { | ||
| vmListResult = this.VirtualMachineClient.ListAllNextWithHttpMessagesAsync(vmListResult.Body.NextPageLink) |
There was a problem hiding this comment.
use "ListNextWithHttpMessagesAsync"
|
Please hold this PR. I think we need to use the updated the client library which will use 2018-10-01 version. (the client library for 2018-10-01 is not yet published) |
Add paging support to Get-AzureRmVM when -ResourceGroupName parameter is set.
jabbera
force-pushed
the
fix-vm-paging-by-rg
branch
from
a0a11d6 to
1450844
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add paging support to Get-AzureRmVM when -ResourceGroupName parameter is set.
Description
Get-AzureRmVM -ResourceGroupName blah is only returning 50 results even if there are more then 50 vms in an RG.
You may not believe me, but this test: https://github.com/Azure/azure-powershell/blob/preview/tools/InstallationTests/NetcoreTests/Compute/VirtualMachineTests.ps1#L1988 is currently failing because the paging code does not exist when filtering by resource group name. I have no idea why it used to work unless more the 50 results used to be returned by the endpoint for this call.
Checklist
CONTRIBUTING.mdplatyPSmodule