Update DataMigration PS to 2018-07-15-preview for Sync Migrations #7287
Conversation
…s for new Sync online migrations
huang91shu
requested review from
maddieclayton,
hitenjava,
MiYanni and
sichoudh
| @@ -47,9 +47,12 @@ | |||
| <PropertyGroup> | |||
| <SignAssembly>false</SignAssembly> | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Powershell|AnyCPU'"> | |||
| <OutputPath>bin\Powershell\</OutputPath> | |||
| </PropertyGroup> | |||
There was a problem hiding this comment.
Removed. Unintentional by visualstudio.
| @@ -19,6 +19,11 @@ | |||
| --> | |||
| ## Current Release | |||
|
|
|||
| ## Version 0.1.7 | |||
There was a problem hiding this comment.
Just put the new changelog notes under Current Release. I'll generate a new header/version when I make the preview module.
| @@ -55,7 +55,7 @@ The above example retrieves the Azure Database Migration project based on PSPro | |||
| The credentials, account, tenant, and subscription used for communication with azure. | |||
|
|
|||
| ```yaml | |||
| Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.IAzureContextContainer | |||
| Type: IAzureContextContainer | |||
There was a problem hiding this comment.
You need to regenerate your help files with the -UseFullTypeName parameter. See: https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module
There was a problem hiding this comment.
Done. How do the online version of the help files get updated? For example:
There was a problem hiding this comment.
The build below is failing because I did not provide an online version of the help documentation.
There was a problem hiding this comment.
@huang91shu ValidateHelpIssues.csv from the build tells you which files need which URLs. Just paste the corresponding URLs into the online version header at the top of those files.
There was a problem hiding this comment.
So the files which need new URLs are the modified cmdlets which require updated online documentation.
New-AzureRmDataMigrationSelectedDBObject.md
New-AzureRmDataMigrationSyncSelectedDBObject.md
This documentation should not currently exist. The new Invoke-Command[...] also does not have online documentation yet.
There was a problem hiding this comment.
The URLs are the URLs where the online documentation will be published. You just copy/paste the URLs into the files. The help files become the online documentation. Please, just paste the URLs it provides in the .csv into the top of the files in the online version tag.
There was a problem hiding this comment.
Gotcha. I misunderstood where to find the URLs. Done.
…edDb cmdlets, sourceDatabase parameter alias
|
@huang91shu Please update the help docs so we can see if the build passes. I'd like to possibly get the preview module out to the test gallery today. |
|
@huang91shu All of your tests failed. Can you take a look? You might need to re-record them. |
NoteThis PR is not for Ignite. |
|
@azuresdkci Retest this please |
|
@huang91shu Looks like 1 test is still failing, |
|
@huang91shu Do you want these changes to go into our next release? If so, I'd just change the target branch back to preview. |
|
Will switch to preview branch once the build passes. Thanks. |
huang91shu
changed the base branch from
AzureRM.DataMigration-preview
to
preview
|
I have a passing build and have switched the branch to preview. Let me know if there is anything pending on our side. |
|
@huang91shu I'll check over this tomorrow. If it looks good, I'll merge it. |
…his will be part of a normal release. Added cmdlets/aliases to Az psd1.
Link to design review:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/155
Description
This new migration type allows an ongoing migration to continuously sync changes between the source and target until the customer completes the migration. This new scenario currently supports two source-target pairs. 1) Sql -> SqlDb, 2) MySql -> MySqlAzure
Checklist
CONTRIBUTING.mdplatyPSmodule