Skip to content

Fix for New-AzureRmRoleAssignment and Remove-AzureRmRoleAssignment fo… #7228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 13, 2018

Conversation

bganapa
Copy link
Member

@bganapa bganapa commented Sep 13, 2018

Description

Fix for New-AzureRmRoleAssignment and Remove-AzureRmRoleAssignment for ADFS scenario

Checklist

@bganapa bganapa requested a review from deathly809 September 13, 2018 00:28
deathly809
deathly809 previously approved these changes Sep 13, 2018
@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

Updated this PR with commits from #7221 which got in to preview already

@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

@maddieclayton Could you please help why these IOTHub tests are failing... I have already retried..

If they are fixed in preview branch.. can we override and merge this PR?

System.Management.Automation.ParameterBindingException : A parameter cannot be found that matches parameter name '-TextExtension'.

@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

@cormacpayne /@markcowl as well if they know about these IOT hub test failures.. I have already retired. Thanks for looking in to this!

@deathly809
Copy link
Member

@bganapa All the admin tests seem to be failing.

Import-Module : The required module 'AzureRM.Profile' is not loaded. Load the 

@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

@deathly809 good catch.. it was my commit that removed a needed psd1 file in the cleanup script, my yesterday night validation run failed as well. Fixed it with the above commit

@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

@deathly809 Asides we should enable failing of the job when the pester tests are failing..

@bganapa
Copy link
Member Author

bganapa commented Sep 13, 2018

@maddieclayton @deathly809 The admin tests are passing now

@bganapa bganapa assigned markcowl and maddieclayton and unassigned deathly809 and bganapa Sep 13, 2018
@maddieclayton maddieclayton merged commit 4d4a682 into Azure:StackAdmin-1.5.0 Sep 13, 2018
ionuttulai pushed a commit to ionuttulai/azure-powershell that referenced this pull request Mar 4, 2020
Fix for New-AzureRmRoleAssignment and Remove-AzureRmRoleAssignment fo…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants