-
Notifications
You must be signed in to change notification settings - Fork 4k
Cmdlets for Azure Backup Vault #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding AzureBackupContainer model (initial draft).
Fixes in AzureBackupContainer class definition.
2. Created ContainerContext base class.
Made some changes according to previous PR.
Adding AzureBackupItemContextObject class and AzureBackupItem.cs file Adding DataSourceType in AzureBackupItemContextObject class
Local Changes for Commandlets
Download Vault Creds (testing pending)
Added Get-AzureBackupItem cmdlet
Get-AzureBackupContainer
Get-AzureBackupContainer
@azuresdkci retest this please |
@@ -7,6 +7,7 @@ | |||
<TestSettings_x64>.\src\Local.x64.testsettings</TestSettings_x64> | |||
<ScenarioTestDebug>.\src\Common\Commands.ScenarioTest\bin\Debug\Microsoft.WindowsAzure.Commands.ScenarioTest.dll</ScenarioTestDebug> | |||
<CommonTestDebug>.\src\Common\Commands.Common.Test\bin\Debug\Microsoft.WindowsAzure.Commands.Common.Test.dll</CommonTestDebug> | |||
<BackupTestDebug>.\src\ResourceManager\AzureBackup\Commands.AzureBackup.Test\bin\Debug\Microsoft.Azure.Commands.AzureBackup.Test.dll</BackupTestDebug> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the indent, make sure using "space" not "tab".
Please fresh across
@swatimadhukar Please respond to review feedback |
@swatimadhukar Please add changes to changelog.txt |
@@ -101,6 +102,7 @@ NestedModules = @( | |||
'.\OperationalInsights\Microsoft.Azure.Commands.OperationalInsights.dll', | |||
'.\UsageAggregates\Microsoft.Azure.Commands.UsageAggregates.dll', | |||
'.\ApiManagement\Microsoft.Azure.Commands.ApiManagement.ServiceManagement.dll' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need a comma at the end of this line
Cmdlets for Azure Backup Vault
huangpf PR: dev <- Azure:dev
Cmdlets for Azure Backup Vault
This PR includes following cmdlets:
Currently we have taken a dependency on azure-sdk-for-net repo for BackupManagementServices.dll which has been checked into azure-powershell repo, once nuget package is available for this we will take nuget dependency and remove the dll.
hydra-spec-pr Pull Request: https://github.com/Azure/hydra-specs-pr/pull/1045
azure-sdk-for-net Pull Request: Azure/azure-sdk-for-net#1216