Skip to content

WORK:3387747 Added new Brooklyn Co-existance feature Powershell commandlets #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

WORK:3387747 Added new Brooklyn Co-existance feature Powershell commandlets #436

wants to merge 3 commits into from

Conversation

Nilambari
Copy link
Member

No description provided.

@azurecla
Copy link

Hi @Nilambari, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nilamd). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@Nilambari
Copy link
Member Author

@stankovski As per your suggestion, I had raised PR request against branch: release-0.9.2 in the afternoon. Can you Please help accept this PR? Thanks a lot!

stankovski
stankovski reviewed May 28, 2015
View reviewed changes
src/ServiceManagement/Network/Commands.Network/Gateway/GetAzureLocalNetworkGateway.cs
[Parameter(Position = 0, Mandatory = false, HelpMessage = "Local network gateway Id.")]
[ValidateGuid]
[ValidateNotNullOrEmpty]
public string gatewayId
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect name casing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stankovski
Copy link
Member

Add tests

@Nilambari
Copy link
Member Author

@stankovski We do not have tests for existing commandlets as well. I have added tests in Sdk-for-net repo for all these new APIs. I have validated all the commandlets work fine. I can definitely work on adding tests for PS cmdlets afterwards, Thanks a lot for the review!

@hovsepm
Copy link
Contributor

hovsepm commented May 30, 2015

Please open PR against Dev branch.

@hovsepm hovsepm closed this May 30, 2015
@Nilambari Nilambari mentioned this pull request Jun 1, 2015
Merged
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Feb 24, 2016
@huangpf
Merge pull request Azure#436 from huangpf/dev
d5a5ba9 
HPF PR: vmss <- huangpf:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nilambari @azurecla @stankovski @hovsepm