-
Notifications
You must be signed in to change notification settings - Fork 4k
AzureRT PR #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzureRT PR #417
Conversation
hyonholee
commented
May 22, 2015
- Combine Get-AzureVMImage and Get-AzureVMImageDetail
- Combine Get-AzureVMExtensionImage and Get-AzureVMExtensionImageDetail
- Fix piping issue of Remove-AzureVMDataDisk and Remove-AzureVMNetworkInterface
- Update the ouput of Remove-AzureAvailabilitySet
- Add Force parameter for Remove-AzureAvailabilitySet
Combine Get-AzureVMExtensionImage and Get-AzureVMExtensionImageDetail
and Remove-AzureVMNetworkInterface
Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
||
namespace Microsoft.Azure.Commands.Compute.Models | ||
{ | ||
public class PSOperationResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's duplicate, and please use the following one:
public class PSOperation
{
public string RequestId { get; set; }
public HttpStatusCode StatusCode { get; set; }
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of child class of PSOperation, so if you use PSOperation and format it, all other cmdlets are affected, and show a wrong format. That is why I created a new class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know what's the specific wrong format about? If something is wrong, it's better to fix it correctly, isn't it?
I have concerns about |
@huangpf, is this ready to be considered for merge? |
@azuresdkci retest this please |
[Parameter( | ||
Mandatory = true, | ||
Position = 1, | ||
ValueFromPipelineByPropertyName = true, | ||
HelpMessage = HelpMessages.VMDataDiskName)] | ||
[ValidateNotNullOrEmpty] | ||
public string Name { get; set; } | ||
public string [] DataDiskNames { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string[]
HPF PR: vmss <- huangpf:dev