Skip to content

Add support for the SetParameters.xml file to override package configuration when publishing a webdeploy package to an azure website. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2015

Conversation

naeemkhedarun
Copy link
Contributor

I've added support for specifying a parameters file when publishing a package to an azure website.

For example:

 Publish-AzureWebsiteProject -Name nymtest -Package .\App.Api.zip -SetParametersFile .\App.Api.SetParameters.xml

Any help getting this merged will be very appreciated! Thanks for the fantastic cmdlets.

…uration when publishing a webdeploy package to an azure website.
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Apr 2, 2015

Hi @naeemkhedarun, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@azurecla
Copy link

azurecla commented Apr 2, 2015

@naeemkhedarun, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

@markcowl
Copy link
Member

@azuresdkci test this please

@naeemkhedarun
Copy link
Contributor Author

@markcowl Hey Mark, if I can help to get this merged or you want any changes made please get in touch!

@naeemkhedarun
Copy link
Contributor Author

@markcowl Hey Mark it has been a few weeks, would you like me to reintegrate this PR with the latest commits?

@markcowl
Copy link
Member

markcowl commented May 4, 2015

@naeemkhedarun Sorry for the delay, We are merging in some private changes today, and we will retun and take a look at the issues once that is complete

@markcowl
Copy link
Member

@naeemkhedarun looks like this makes the publish-azurewebsites tests fail. Can you take a look?

@naeemkhedarun
Copy link
Contributor Author

Thanks @markcowl I'll get this sorted!

@markcowl
Copy link
Member

@naeemkhedarun Code complete is today. Can you please update this?

@naeemkhedarun
Copy link
Contributor Author

@markcowl working on it now!

@naeemkhedarun
Copy link
Contributor Author

@azuresdkci test this please

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@markcowl
Copy link
Member

@NaveenGoli Can you review this PR please?

@stankovski
Copy link
Member

@azuresdkci retest this please

@NaveenGoli
Copy link
Contributor

revierwed

hovsepm pushed a commit that referenced this pull request May 26, 2015
Add support for the SetParameters.xml file to override package configuration when publishing a webdeploy package to an azure website.
@hovsepm hovsepm merged commit 2be1493 into Azure:dev May 26, 2015
markcowl pushed a commit that referenced this pull request Jan 14, 2016
hovsepm pushed a commit that referenced this pull request May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants