Skip to content

[Relay] Add dedicated cluster support (2026-07-01-preview) - #30230

Open
pbharali-microsoft wants to merge 5 commits into
Azure:mainfrom
pbharali-microsoft:relay-clusters-2026-07-preview
Open

pbharali-microsoft wants to merge 5 commits into
Azure:mainfrom
pbharali-microsoft:relay-clusters-2026-07-preview

Conversation

@pbharali-microsoft

@pbharali-microsoft pbharali-microsoft commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ⚠️ Review suggested

Tests
⚠️ 20/20
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Relay
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzRelayAuthorizationRule Get-AzRelayAuthorizationRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayAuthorizationRule Get-AzRelayAuthorizationRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayCluster Get-AzRelayCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayCluster Get-AzRelayCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterAvailableClusterRegion Get-AzRelayClusterAvailableClusterRegion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterAvailableClusterRegion Get-AzRelayClusterAvailableClusterRegion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterNamespace Get-AzRelayClusterNamespace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterNamespace Get-AzRelayClusterNamespace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterSku Get-AzRelayClusterSku Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterSku Get-AzRelayClusterSku changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayHybridConnection Get-AzRelayHybridConnection Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayHybridConnection Get-AzRelayHybridConnection changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayNamespace Get-AzRelayNamespace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayNamespace Get-AzRelayNamespace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayNamespaceNetworkRuleSet Get-AzRelayNamespaceNetworkRuleSet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayNamespaceNetworkRuleSet Get-AzRelayNamespaceNetworkRuleSet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWcfRelay Get-AzWcfRelay Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWcfRelay Get-AzWcfRelay changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzRelayNetworkRuleSetIPRuleObject New-AzRelayNetworkRuleSetIPRuleObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzRelayAuthorizationRule Get-AzRelayAuthorizationRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayAuthorizationRule Get-AzRelayAuthorizationRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayCluster Get-AzRelayCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayCluster Get-AzRelayCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterAvailableClusterRegion Get-AzRelayClusterAvailableClusterRegion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterAvailableClusterRegion Get-AzRelayClusterAvailableClusterRegion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterNamespace Get-AzRelayClusterNamespace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterNamespace Get-AzRelayClusterNamespace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayClusterSku Get-AzRelayClusterSku Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayClusterSku Get-AzRelayClusterSku changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayHybridConnection Get-AzRelayHybridConnection Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayHybridConnection Get-AzRelayHybridConnection changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayNamespace Get-AzRelayNamespace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayNamespace Get-AzRelayNamespace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRelayNamespaceNetworkRuleSet Get-AzRelayNamespaceNetworkRuleSet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRelayNamespaceNetworkRuleSet Get-AzRelayNamespaceNetworkRuleSet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWcfRelay Get-AzWcfRelay Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWcfRelay Get-AzWcfRelay changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzRelayNetworkRuleSetIPRuleObject New-AzRelayNetworkRuleSetIPRuleObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Description

Retargets Az.Relay from API version 2026-01-01 to 2026-07-01-preview (tag package-2026-07-preview) and regenerates, adding Relay dedicated cluster support.

New cmdlets

  • Get-AzRelayCluster, New-AzRelayCluster, Set-AzRelayCluster, Update-AzRelayCluster, Remove-AzRelayCluster
  • Get-AzRelayClusterNamespace, Get-AzRelayClusterSku, Get-AzRelayClusterAvailableClusterRegion

Updated cmdlets

  • New-AzRelayNamespace / Update-AzRelayNamespace gain optional -ClusterArmId (assigns a namespace to a dedicated cluster) and -MinimumTlsVersion.

Notes

  • The spec readme moved to Microsoft.Relay/Relay/readme.md when Relay converted to TypeSpec, so the autorest require: path is updated alongside the commit: pin (bb83f364).
  • RequiredModules Az.Accounts 5.3.1 to 5.5.3 reflects the current version in main; the committed manifest was stale.
  • Change is purely additive: no cmdlet removed or renamed, no existing parameter dropped.
  • Examples are provided for all eight new cmdlets. Generated test stubs are -skip, matching the existing module.

Checklist

  • The title of the PR is clear and informative.
  • The appropriate change log has been updated under ## Upcoming Release.
  • The PR does not introduce breaking changes

Copilot AI balanced review requested due to automatic review settings October 1, 2026 06:50
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The checked-in generated nested module lacks the exported cluster cmdlets and new namespace parameters.

Review effort: Balanced
Findings: 2 High severity · 7 Low severity

Open (9)
What changed in this PR

Retargets Az.Relay to 2026-07-01-preview and introduces dedicated Relay cluster management.

Changes:

  • Adds eight cluster cmdlet surfaces, examples, help, and test stubs.
  • Adds namespace cluster assignment and minimum TLS parameters.
  • Updates AutoRest configuration, API metadata, exports, and changelog.
File Description
src/​Relay/​Relay/​help/​Update-AzRelayNamespace.md Documents new namespace parameters.
src/​Relay/​Relay/​help/​Update-AzRelayCluster.md Adds cluster PATCH help.
src/​Relay/​Relay/​help/​Test-AzRelayName.md Refreshes subscription help.
src/​Relay/​Relay/​help/​Set-AzRelayCluster.md Adds cluster PUT help.
src/​Relay/​Relay/​help/​Remove-AzWcfRelay.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Remove-AzRelayNamespace.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Remove-AzRelayHybridConnection.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Remove-AzRelayCluster.md Adds cluster deletion help.
src/​Relay/​Relay/​help/​New-AzWcfRelay.md Refreshes parameter help.
src/​Relay/​Relay/​help/​New-AzRelayNamespace.md Documents new namespace parameters.
src/​Relay/​Relay/​help/​New-AzRelayKey.md Refreshes parameter help.
src/​Relay/​Relay/​help/​New-AzRelayHybridConnection.md Refreshes parameter help.
src/​Relay/​Relay/​help/​New-AzRelayCluster.md Adds cluster creation help.
src/​Relay/​Relay/​help/​New-AzRelayAuthorizationRule.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzWcfRelay.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzRelayNamespaceNetworkRuleSet.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzRelayNamespace.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzRelayKey.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzRelayHybridConnection.md Refreshes parameter help.
src/​Relay/​Relay/​help/​Get-AzRelayClusterSku.md Adds cluster SKU help.
src/​Relay/​Relay/​help/​Get-AzRelayClusterNamespace.md Adds cluster namespace help.
src/​Relay/​Relay/​help/​Get-AzRelayClusterAvailableClusterRegion.md Adds availability help.
src/​Relay/​Relay/​help/​Get-AzRelayCluster.md Adds cluster retrieval help.
src/​Relay/​Relay/​help/​Az.Relay.md Indexes cluster cmdlets.
src/​Relay/​Relay/​ChangeLog.md Records user-facing additions.
src/​Relay/​Relay/​Az.Relay.psd1 Updates dependency and exports.
src/​Relay/​Relay.sln Refreshes generated project GUID.
src/​Relay/​Relay.Autorest/​UX/​Microsoft.Relay/​namespaces.json Updates namespace API version.
src/​Relay/​Relay.Autorest/​UX/​Microsoft.Relay/​namespaces-wcfRelays.json Updates WCF API version.
src/​Relay/​Relay.Autorest/​UX/​Microsoft.Relay/​namespaces-hybridConnections.json Updates hybrid API version.
src/​Relay/​Relay.Autorest/​UX/​Microsoft.Relay/​clusters.json Adds cluster UX metadata.
src/​Relay/​Relay.Autorest/​test/​Update-AzRelayCluster.Tests.ps1 Adds generated test stubs.
src/​Relay/​Relay.Autorest/​test/​Set-AzRelayCluster.Tests.ps1 Adds generated test stubs.
src/​Relay/​Relay.Autorest/​test/​Remove-AzRelayCluster.Tests.ps1 Adds generated test stubs.
src/​Relay/​Relay.Autorest/​test/​New-AzRelayCluster.Tests.ps1 Adds generated test stubs.
src/​Relay/​Relay.Autorest/​test/​Get-AzRelayClusterSku.Tests.ps1 Adds generated test stub.
src/​Relay/​Relay.Autorest/​test/​Get-AzRelayClusterNamespace.Tests.ps1 Adds generated test stub.
src/​Relay/​Relay.Autorest/​test/​Get-AzRelayClusterAvailableClusterRegion.Tests.ps1 Adds generated test stub.
src/​Relay/​Relay.Autorest/​test/​Get-AzRelayCluster.Tests.ps1 Adds generated test stubs.
src/​Relay/​Relay.Autorest/​README.md Pins preview API specification.
src/​Relay/​Relay.Autorest/​Properties/​AssemblyInfo.cs Changes assembly versions.
src/​Relay/​Relay.Autorest/​generate-info.json Refreshes generation identifier.
src/​Relay/​Relay.Autorest/​examples/​Update-AzRelayCluster.md Adds cluster PATCH examples.
src/​Relay/​Relay.Autorest/​examples/​Set-AzRelayCluster.md Adds cluster PUT example.
src/​Relay/​Relay.Autorest/​examples/​Remove-AzRelayCluster.md Adds deletion examples.
src/​Relay/​Relay.Autorest/​examples/​New-AzRelayCluster.md Adds creation examples.
src/​Relay/​Relay.Autorest/​examples/​Get-AzRelayClusterSku.md Adds SKU example.
src/​Relay/​Relay.Autorest/​examples/​Get-AzRelayClusterNamespace.md Adds namespace example.
src/​Relay/​Relay.Autorest/​examples/​Get-AzRelayClusterAvailableClusterRegion.md Adds availability example.
src/​Relay/​Relay.Autorest/​examples/​Get-AzRelayCluster.md Adds retrieval examples.
src/​Relay/​Relay.Autorest/​docs/​Update-AzRelayNamespace.md Documents new namespace parameters.
src/​Relay/​Relay.Autorest/​docs/​Update-AzRelayCluster.md Adds generated PATCH docs.
src/​Relay/​Relay.Autorest/​docs/​Test-AzRelayName.md Refreshes subscription docs.
src/​Relay/​Relay.Autorest/​docs/​Set-AzRelayCluster.md Adds generated PUT docs.
src/​Relay/​Relay.Autorest/​docs/​Remove-AzWcfRelay.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Remove-AzRelayNamespace.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Remove-AzRelayHybridConnection.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Remove-AzRelayCluster.md Adds generated deletion docs.
src/​Relay/​Relay.Autorest/​docs/​New-AzWcfRelay.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​New-AzRelayNamespace.md Documents new namespace parameters.
src/​Relay/​Relay.Autorest/​docs/​New-AzRelayKey.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​New-AzRelayHybridConnection.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​New-AzRelayCluster.md Adds generated creation docs.
src/​Relay/​Relay.Autorest/​docs/​New-AzRelayAuthorizationRule.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzWcfRelay.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayNamespaceNetworkRuleSet.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayNamespace.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayKey.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayHybridConnection.md Refreshes parameter docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayClusterSku.md Adds generated SKU docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayClusterNamespace.md Adds generated namespace docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayClusterAvailableClusterRegion.md Adds generated availability docs.
src/​Relay/​Relay.Autorest/​docs/​Get-AzRelayCluster.md Adds generated retrieval docs.
src/​Relay/​Relay.Autorest/​docs/​Az.Relay.md Updates generated help index.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Relay/Relay.Autorest/Properties/AssemblyInfo.cs
Comment on lines +72 to +74
FunctionsToExport = 'Get-AzRelayAuthorizationRule', 'Get-AzRelayCluster',
'Get-AzRelayClusterAvailableClusterRegion',
'Get-AzRelayClusterNamespace', 'Get-AzRelayClusterSku',
Comment thread src/Relay/Relay.Autorest/docs/New-AzRelayNamespace.md
Comment thread src/Relay/Relay.Autorest/docs/Set-AzRelayCluster.md
Comment thread src/Relay/Relay.Autorest/docs/Update-AzRelayNamespace.md
Comment thread src/Relay/Relay.Autorest/examples/Set-AzRelayCluster.md
Comment thread src/Relay/Relay/help/New-AzRelayNamespace.md
Comment thread src/Relay/Relay/help/Set-AzRelayCluster.md
Comment thread src/Relay/Relay/help/Update-AzRelayNamespace.md
Copilot AI balanced review requested due to automatic review settings October 1, 2026 08:46
@pbharali-microsoft
pbharali-microsoft force-pushed the relay-clusters-2026-07-preview branch from 745c117 to 183b121 Compare October 1, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Still open (9)

Retargets Az.Relay from API version 2026-01-01 to 2026-07-01-preview via
tag package-2026-07-preview, and regenerates.

Adds Relay dedicated cluster cmdlets:
  Get-AzRelayCluster, New-AzRelayCluster, Set-AzRelayCluster,
  Update-AzRelayCluster, Remove-AzRelayCluster,
  Get-AzRelayClusterNamespace, Get-AzRelayClusterSku,
  Get-AzRelayClusterAvailableClusterRegion

Namespace cmdlets gain optional -ClusterArmId, used to assign a namespace
to a dedicated cluster, and -MinimumTlsVersion.

The spec readme moved to Microsoft.Relay/Relay/readme.md when Relay
converted to TypeSpec, so the autorest require path is updated alongside
the commit pin.

The change is purely additive: no cmdlet is removed or renamed and no
existing parameter is dropped. Examples are provided for all eight new
cmdlets; generated test stubs are skipped, matching the existing module.
Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:51
@pbharali-microsoft
pbharali-microsoft force-pushed the relay-clusters-2026-07-preview branch from 183b121 to d61f7ee Compare October 1, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- $(repo)/specification/relay/resource-manager/readme.md
- $(repo)/specification/relay/resource-manager/Microsoft.Relay/Relay/readme.md

tag: package-2026-07-preview
@pbharali-microsoft

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Commenter does not have sufficient privileges for PR 30230 in repo Azure/azure-powershell

@@ -0,0 +1,33 @@
if(($null -eq $TestName) -or ($TestName -contains 'Get-AzRelayCluster'))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test files are added but no tests are added. Please add and record accordingly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests & recordings

@NoriZC NoriZC self-assigned this Oct 12, 2026
@github-actions

Copy link
Copy Markdown

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:17
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +47 to +49
$["x-ms-long-running-operation"] = true;
$["x-ms-long-running-operation-options"] = { "final-state-via": "azure-async-operation" };
if (!$.responses["202"]) { $.responses["202"] = { "description": "Accepted." }; }
Comment on lines +174 to +176
if ($hasAsJob) {
$PSBoundParameters.Add('AsJob', $true)
}
Comment thread src/Relay/Relay.Autorest/examples/Set-AzRelayCluster.md Outdated
Comment thread src/Relay/Relay.Autorest/examples/Set-AzRelayCluster.md Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The PR contains a nonfunctional example, an untested capacity path, and a manual AssemblyInfo change rejected by repository validation.

5 open findings
1 resolved since last review
Previously missed (2)

In code that hasn't changed since last review

Medium severity Add test coverage for Capacity-to-SkuCapacity mutation

src/​Relay/​Relay.Autorest/​test/​Set-AzRelayCluster.Tests.ps1:25

This test only exercises the tag path, leaving the custom wrapper's distinct Capacity mutation (SkuCapacity = $Capacity) unverified. Add a recorded -Capacity invocation and assert the returned and re-read SkuCapacity; this would also catch the invalid capacity parameter currently used by the example.

Low severity Fix invalid SkuCapacity parameter in Set-AzRelayCluster example

src/​Relay/​Relay.Autorest/​examples/​Set-AzRelayCluster.md:3

Set-AzRelayCluster exposes -Capacity, not -SkuCapacity, so this example fails parameter binding when copied. Change the source example to -Capacity 2 and regenerate both documentation copies.

🧠 Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI balanced review requested due to automatic review settings October 13, 2026 11:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- $(repo)/specification/relay/resource-manager/readme.md
- $(repo)/specification/relay/resource-manager/Microsoft.Relay/Relay/readme.md

tag: package-2026-07-preview
- $(repo)/specification/relay/resource-manager/readme.md
- $(repo)/specification/relay/resource-manager/Microsoft.Relay/Relay/readme.md

tag: package-2026-07-preview
@@ -0,0 +1,12 @@
### Example 1: Update a Relay dedicated cluster
```powershell
Set-AzRelayCluster -ResourceGroupName lucas-relay-rg -Name relaycluster01 -SkuCapacity 2
Comment on lines +18 to +19
It 'List' -skip {
{ throw [System.NotImplementedException] } | Should -Not -Throw
Comment thread src/Relay/Relay.Autorest/test/Get-AzRelayClusterNamespace.Tests.ps1 Outdated
Comment on lines +18 to +19
It 'List' -skip {
{ throw [System.NotImplementedException] } | Should -Not -Throw
Comment on lines +18 to +19
It 'CreateExpanded' -skip {
{ throw [System.NotImplementedException] } | Should -Not -Throw
Comment on lines +18 to +19
It 'Delete' -skip {
{ throw [System.NotImplementedException] } | Should -Not -Throw
Comment thread src/Relay/Relay.Autorest/test/Update-AzRelayCluster.Tests.ps1 Outdated
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI balanced review requested due to automatic review settings October 13, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

@@ -0,0 +1,121 @@
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Relay","Get-AzRelayAuthorizationRule","Get-AzRelayAuthorizationRule","0","3010","The property 'SystemDataCreatedAt' of type 'Microsoft.Azure.PowerShell.Cmdlets.Relay.Models.IAuthorizationRule' has been removed.","Add the property 'SystemDataCreatedAt' back to type 'Microsoft.Azure.PowerShell.Cmdlets.Relay.Models.IAuthorizationRule'."
Comment on lines +177 to +181
# Remove the duplicate Update-AzRelayCluster entirely; Set-AzRelayCluster covers the same scenario.
- where:
verb: Update
subject: ^Cluster$
remove: true
Comment on lines +154 to +157
if ($hasCapacity) {
$cluster.SkuCapacity = $SkuCapacity
$hasProperty = $true
}
Comment on lines +18 to +19
[-ClusterArmId <String>] [-MinimumTlsVersion <String>] [-SkuTier <String>] [-Tag <Hashtable>]
[-DefaultProfile <PSObject>] [-AsJob] [-NoWait] [-Confirm] [-WhatIf] [<CommonParameters>]
Comment on lines +20 to +21
[-ClusterArmId <String>] [-MinimumTlsVersion <String>] [-Tag <Hashtable>] [-DefaultProfile <PSObject>]
[-AsJob] [-NoWait] [-Confirm] [-WhatIf] [<CommonParameters>]
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants