Repository navigation
Fix Hub virtual network IPv6 peering contract - #30154
Merged
Yabo Hu (VeryEarly) merged 6 commits intoSep 23, 2026
Merged
Yabo Hu (VeryEarly) merged 6 commits into
Yabo Hu (VeryEarly) merged 6 commits into
Conversation
Contributor
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
carenlim20
changed the title
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
The hub virtual network connection IPv6 peering property is a boolean on the wire, so expose it as a boolean instead of an Enabled/Disabled string and use the canonical IPv6 casing. This removes the string conversions in the mapping profile, which are no longer needed now that the names and types match. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Re-recorded TestVirtualHubEnableOnlyIpv6PeeringCRUD against live NRP using the boolean -EnableOnlyIPv6Peering cmdlet surface. The recorded PUT request body now sends canonical enableOnlyIPv6Peering: true, and all responses use the same canonical casing, matching NRP deployed contract. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tract The HubVirtualNetworkConnection IPv6 peering property was corrected to the canonical "enableOnlyIPv6Peering" boolean contract deployed by NRP. This renames the cmdlet parameter and PS model property, which static analysis reports as breaking changes (3010, 2000, 1050). The 1050 parameter-set errors are a cascade: the parameter had no ParameterSetName, so it lived in __AllParameterSets and surfaced in every set. All parameter sets remain intact in source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The directive overrode a shared swagger enum to boolean for enableOnlyIpv6Peering. That enum no longer exists: at the pinned spec commit e6556d8af59d346de05e19d4e6dd7d0d6b67c128, both common.json and virtualWan.json declare enableOnlyIPv6Peering directly as "type": "boolean". The `where` clause matches nothing, so the transform never runs. Verified by regenerating the SDK with the directive removed: zero non-whitespace changes across all 1837 generated files. Leaving it in place is misleading to anyone regenerating the SDK, since it implies the spec still ships an enum for this property. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
carenlim20
force-pushed
the
enableOnlyIPv6Peering-boolean
branch
from
September 21, 2026 21:52
ac536f7 to
18b00bd
Compare
Collaborator
|
/azp run azure-powershell - security-tools |
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
network module has PS model layer so no breaking changes are suppose to happen, please map the new SDK model to PS model instead of claiming breaking changes |
carenlim20
force-pushed
the
enableOnlyIPv6Peering-boolean
branch
from
September 22, 2026 00:13
18b00bd to
a464f78
Compare
carenlim20
changed the title
carenlim20
changed the title
carenlim20
force-pushed
the
enableOnlyIPv6Peering-boolean
branch
4 times, most recently
from
September 22, 2026 03:03
7aba19c to
18b00bd
Compare
Map the SDK boolean contract through the PS model layer instead of changing the cmdlet surface, so no breaking changes are introduced. The cmdlet and AutoMapper profile translate Enabled/Disabled to the boolean enableOnlyIPv6Peering property the service expects. Removes the breaking change suppressions, which are no longer needed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run azure-powershell - security-tools |
Contributor
|
Commenter does not have sufficient privileges for PR 30154 in repo Azure/azure-powershell |
Collaborator
|
/azp run azure-powershell - security-tools |
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Yabo Hu (VeryEarly)
approved these changes
Sep 23, 2026
Yabo Hu (VeryEarly)
enabled auto-merge (squash)
September 23, 2026 05:42
Yabo Hu (VeryEarly)
merged commit Sep 23, 2026
c14cefe
into
Azure:release-network-2026-01-01
12 checks passed
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.Maintenance
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Resources
️✔️Az.Security
️✔️Az.ServiceBus
️✔️Az.Sql
️✔️Az.Storage
️✔️Az.Websites
Description
Network SDK has enableOnlyIPv6Peering as a bool now, but powershell has to remain as string. Fixed
-EnableOnlyIpv6PeeringonNew-AzVirtualHubVnetConnectionso that theEnabledandDisabledvalues are correctly translated to the booleanenableOnlyIPv6Peeringproperty expected by the service.The swagger PR with "BreakingChange-Approved-BugFix" approval/label: Azure/azure-rest-api-specs#45637
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.