Skip to content

Onboard HorizonDB to Private Link common cmdlets - #29764

Merged
necusjz merged 2 commits into
Azure:mainfrom
petarperin-mdcs:dev/petarperin/hdb-pe-ps
Jun 29, 2026
Merged

Onboard HorizonDB to Private Link common cmdlets#29764
necusjz merged 2 commits into
Azure:mainfrom
petarperin-mdcs:dev/petarperin/hdb-pe-ps

Conversation

@petarperin-mdcs

@petarperin-mdcs petarperin-mdcs commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Onboards HorizonDB clusters to the existing generic Az.Network Private Link common cmdlets by registering Microsoft.HorizonDB/clusters in the Private Link provider map.

This enables the generic cmdlet flows for HorizonDB cluster resource IDs:

Get-AzPrivateLinkResource -PrivateLinkResourceId $clusterId
Get-AzPrivateEndpointConnection -PrivateLinkResourceId $clusterId
Approve-AzPrivateEndpointConnection -ResourceId $privateEndpointConnectionId
Deny-AzPrivateEndpointConnection -ResourceId $privateEndpointConnectionId
Remove-AzPrivateEndpointConnection -ResourceId $privateEndpointConnectionId

No new cmdlets, parameters, or markdown help regeneration are needed because this is provider-map-only onboarding for existing common cmdlets.

Validation performed:

  • Built Az.Network successfully with dotnet msbuild build.proj /p:Scope=Network.
  • Verified the built provider map contains Microsoft.HorizonDB/clusters, API version 2026-01-20-preview, HasConnectionsURI = true, SupportGetPrivateLinkResource = true, and SupportListPrivateLinkResource = true.
  • Validated read flows against a live HorizonDB cluster:
    • Get-AzPrivateLinkResource -PrivateLinkResourceId $clusterId
    • Get-AzPrivateLinkResource -PrivateLinkResourceId $clusterId -Name DefaultPool
    • Get-AzPrivateEndpointConnection -PrivateLinkResourceId $clusterId
    • Get-AzPrivateEndpointConnection -ResourceId $privateEndpointConnectionId
  • Validated full disposable private endpoint lifecycle against a live HorizonDB cluster in UK South:
    • Created two manual private endpoints.
    • Approved one private endpoint connection.
    • Rejected one private endpoint connection.
    • Removed both validation private endpoint connections.
    • Confirmed no validation private endpoint connections remained.
    • Deleted and confirmed cleanup of the disposable validation resource group.

Note: HorizonDB approval and rejection complete asynchronously. The generic cmdlet returns immediately after PUT plus immediate GET, so the immediate output can still show Pending; follow-up Get-AzPrivateEndpointConnection reaches final Approved or Rejected.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Register Microsoft.HorizonDB/clusters in the Az.Network generic Private Link provider map and document the onboarding in the Network changelog.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 24, 2026 14:00
@azure-client-tools-bot-prd

Copy link
Copy Markdown
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR onboards HorizonDB clusters (Microsoft.HorizonDB/clusters) into Az.Network’s existing Private Link common cmdlet flow by adding the resource type to the Private Link provider configuration map.

Changes:

  • Registered Microsoft.HorizonDB/clusters in the Private Link provider map with API version 2026-01-20-preview.
  • Added a Network module changelog entry describing the onboarding.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs Adds Microsoft.HorizonDB/clusters to the provider configuration map so generic Private Link cmdlets can resolve the correct API version and capabilities.
src/Network/Network/ChangeLog.md Documents the onboarding in the Network module “Upcoming Release” notes.

Comment thread src/Network/Network/ChangeLog.md Outdated
@thomas-temby

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

Remove trailing punctuation from the HorizonDB Private Link changelog entry to match neighboring provider onboarding entries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@petarperin-mdcs

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Commenter does not have sufficient privileges for PR 29764 in repo Azure/azure-powershell

@petarperin-mdcs

Copy link
Copy Markdown
Member Author

@yonzhan thank you for the quick response on our other PRs, could you help us getting a review on this one as well? This should be one of the last things we need for HorizonDB NRP compliance

@necusjz

necusjz commented Jun 29, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@necusjz
necusjz merged commit c5c6a09 into Azure:main Jun 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants