Skip to content

Thomas temby/fix sign pipeline - #29754

Merged
thomas-temby merged 4 commits into
mainfrom
thomas-temby/fix-sign-pipeline
Jun 23, 2026
Merged

Thomas temby/fix sign pipeline#29754
thomas-temby merged 4 commits into
mainfrom
thomas-temby/fix-sign-pipeline

Conversation

@thomas-temby

Copy link
Copy Markdown
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings June 22, 2026 05:20
@azure-client-tools-bot-prd

Copy link
Copy Markdown
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MSI generation script used by the Azure PowerShell installer packaging flow to support building in environments where Windows Installer ICE validation can’t run (e.g., containerized builds), while keeping existing validation behavior by default.

Changes:

  • Adds an AZPS_SKIP_MSI_ICE_VALIDATION environment-variable switch to control whether WiX light runs ICE validation.
  • When the switch is enabled ('true'), passes -sval to light to suppress validation; otherwise retains the prior behavior (-sice:ICE80).

@thomas-temby
thomas-temby merged commit 61eff37 into main Jun 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants