-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.SqlVirtualMachine] Update Autorest v3 to v4 #29156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JiaSeng-v
wants to merge
5
commits into
Azure:main
Choose a base branch
from
JiaSeng-v:jiaseng/main/SqlVirtualMachine-v4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1bc5510
[Az.SqlVirtualMachine] Update Autorest v3 to v4
JiaSeng-v df28161
update exceptions
JiaSeng-v 2cc73ca
Revert "update exceptions"
JiaSeng-v 2c91beb
Revert "[Az.SqlVirtualMachine] Update Autorest v3 to v4"
JiaSeng-v d64f1ac
revert prev changes and rebuild with new changes
JiaSeng-v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
src/SqlVirtualMachine/SqlVirtualMachine.Autorest/Properties/AssemblyInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||||||
| // Licensed under the Apache License, Version 2.0 (the ""License""); | ||||||
| // you may not use this file except in compliance with the License. | ||||||
| // You may obtain a copy of the License at | ||||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| // Unless required by applicable law or agreed to in writing, software | ||||||
| // distributed under the License is distributed on an ""AS IS"" BASIS, | ||||||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| // See the License for the specific language governing permissions and | ||||||
| // limitations under the License. | ||||||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | ||||||
|
||||||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | |
| // Code generated by Microsoft (R) AutoRest Code Generator. Changes may cause incorrect behavior and will be lost if the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,15 +37,25 @@ try-require: | |
| - $(repo)/specification/sqlvirtualmachine/resource-manager/readme.powershell.md | ||
|
|
||
| inlining-threshold: 100 | ||
| resourcegroup-append: true | ||
| nested-object-to-string: true | ||
| identity-correction-for-post: true | ||
|
|
||
| # For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option | ||
| use-extension: | ||
| "@autorest/powershell": "3.x" | ||
| disable-transform-identity-type: true | ||
|
|
||
| directive: | ||
| - remove-operation: | ||
| - SqlVirtualMachineGroups_Update | ||
| - from: swagger-document | ||
| where: $.definitions.SqlVirtualMachineGroupProperties.properties.wsfcDomainProfile | ||
| transform: $['x-ms-mutability'] = ["read", "update", "create"] | ||
| - from: swagger-document | ||
|
Comment on lines
42
to
+48
|
||
| where: $.definitions.WsfcDomainProfile.properties..x-ms-mutability | ||
| transform: >- | ||
| return [ | ||
| "read", | ||
| "update", | ||
| "create" | ||
| ] | ||
| - from: swagger-document | ||
| where: $.definitions.SqlVirtualMachineProperties.properties.sqlVirtualMachineGroupResourceId | ||
| transform: $['x-ms-mutability'] = ["read", "update", "create"] | ||
| #1. [swagger] define password parameters as password type | ||
| - from: swagger-document | ||
| where: $.definitions..storageAccountPrimaryKey | ||
|
|
@@ -134,8 +144,8 @@ directive: | |
| hide: true | ||
| #8. [cmdlet] add model cmdlet | ||
| - model-cmdlet: | ||
| - AgReplica | ||
| - MultiSubnetIPConfiguration | ||
| - model-name: AgReplica | ||
| - model-name: MultiSubnetIPConfiguration | ||
| #9. [parameter] rename parameters | ||
| - where: | ||
| parameter-name: SqlVirtualMachineGroupName | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license header comment contains doubled quotes (e.g., ""License"", ""AS IS"") which reduces readability and looks like an escaping artifact. Please update these comment strings to the standard Apache 2.0 header wording with normal quotes.