Skip to content

Conversation

@JunKai-v
Copy link

@JunKai-v JunKai-v commented Feb 3, 2026

Description

Migration PR: #29122

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings February 3, 2026 04:33
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds breaking-change preannouncement messaging for Az.DataProtection cmdlets (Az v16.0.0 / May 2026) and updates DataProtection module metadata/artifacts after the related migration.

Changes:

  • Added preview/breaking-change announcement banners (PreviewMessage / preview-announcement) across DataProtection cmdlets.
  • Updated module metadata (versions/IDs) and solution references.
  • Regenerated/updated markdown help content.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 21 comments.

Show a summary per file
File Description
src/DataProtection/DataProtection/help/Update-AzDataProtectionResourceGuard.md Help text update (contains a new typo).
src/DataProtection/DataProtection/help/Update-AzDataProtectionBackupVault.md Help text update for CMK/UAMI example (introduces incorrect wording/parameter reference).
src/DataProtection/DataProtection/help/Update-AzDataProtectionBackupInstance.md Help text update (contains a new typo).
src/DataProtection/DataProtection/help/Undo-AzDataProtectionBackupInstanceDeletion.md Help text update (contains new typos).
src/DataProtection/DataProtection/help/Start-AzDataProtectionBackupInstanceRestore.md Help text update (contains multiple new typos).
src/DataProtection/DataProtection/help/New-AzDataProtectionPolicyTriggerScheduleClientObject.md Help text update (contains a new typo).
src/DataProtection/DataProtection/help/New-AzDataProtectionBackupPolicy.md Help text update (contains new typos).
src/DataProtection/DataProtection/help/New-AzDataProtectionBackupInstance.md Help text + example updates (example variable typo + narrative typo).
src/DataProtection/DataProtection/help/Get-AzDataProtectionBackupVault.md Help text update (contains new typos).
src/DataProtection/DataProtection/help/Find-AzDataProtectionRestorableTimeRange.md Help text update (contains new typos).
src/DataProtection/DataProtection/Az.DataProtection.psd1 Module manifest updated (version/date/manifest formatting).
src/DataProtection/DataProtection.sln Updated solution project GUID mapping for Az.DataProtection.
src/DataProtection/DataProtection.Autorest/generate-info.json Regeneration identifier updated.
src/DataProtection/DataProtection.Autorest/docs/Az.DataProtection.md Module docs metadata updated (Module Guid).
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/New-AzDataProtectionRetentionLifeCycleClientObject.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/New-AzDataProtectionPolicyTagCriteriaClientObject.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/New-AzDataProtectionBackupPolicy.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/Get-AzDataProtectionPolicyTemplate.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/Edit-AzDataProtectionPolicyTriggerClientObject.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/Edit-AzDataProtectionPolicyTagClientObject.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/Edit-AzDataProtectionPolicyRetentionRuleClientObject.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Vault/Update-AzDataProtectionBackupVault.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Vault/Set-AzDataProtectionMSIPermission.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Vault/New-AzDataProtectionBackupVault.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Restore/Test-AzDataProtectionBackupInstanceRestore.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Restore/Start-AzDataProtectionBackupInstanceRestore.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Restore/Initialize-AzDataProtectionRestoreRequest.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Job/Get-AzDataProtectionJob.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/BackupInstance/Suspend-AzDataProtectionBackupInstanceBackup.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/BackupInstance/Stop-AzDataProtectionBackupInstanceProtection.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Common/Update-AzDataProtectionResourceGuard.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Common/New-AzDataProtectionResourceGuard.ps1 Added breaking-change PreviewMessage banner to custom cmdlet.
src/DataProtection/DataProtection.Autorest/README.md Added AutoRest directive to apply preview-announcement message (missing directive comment).
src/DataProtection/DataProtection.Autorest/Properties/AssemblyInfo.cs Bumped assembly versions (2.8.0 → 2.9.0).

```

The first command is used to fetch the backup instances which are in soft deleted for a give backup vault.
The first comamnd is used to fetch the backup instances which are in soft deleted for a give backup vault.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "comamnd" should be "command".

Copilot uses AI. Check for mistakes.
The last command triggers the restore for AzureDatabaseForPGFlexServer.

### Example 10: Trigger vaulted backup containers ItemLevelRestore with PrefixMatch for Azureblob.
### Example 10: Trigger vaulted backup conatiners ItemLevelRestore with PrefixMatch for Azureblob.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in heading: "conatiners" should be "containers".

Suggested change
### Example 10: Trigger vaulted backup conatiners ItemLevelRestore with PrefixMatch for Azureblob.
### Example 10: Trigger vaulted backup containers ItemLevelRestore with PrefixMatch for Azureblob.

Copilot uses AI. Check for mistakes.
The seventh command updates the policy object with custom schedule.
The eighth, ninth, tenth commands update the Monthly retention rule with custom lifecycles.
The eleventh, twelfth commands create a tag criteria for Monthly policy.
The eleventh, twelth commands create a tag criteria for Monthly policy.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "twelth" should be "twelfth".

Suggested change
The eleventh, twelth commands create a tag criteria for Monthly policy.
The eleventh, twelfth commands create a tag criteria for Monthly policy.

Copilot uses AI. Check for mistakes.
The sixth command assigns the necessary permissions for configure backup.

The seventh and eight command initializes custom tags and configure backup finally by creating a backup instance.
The sevnth and eight command initializes custom tags and configure backup finally by creating a backup instance.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "sevnth" should be "seventh".

Suggested change
The sevnth and eight command initializes custom tags and configure backup finally by creating a backup instance.
The seventh and eighth commands initialize custom tags and configure backup finally by creating a backup instance.

Copilot uses AI. Check for mistakes.
Start-Sleep -Seconds 10
}
$backupinstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject
$backupnstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example variable name "$backupnstanceCreate" looks like a typo (missing "I") and is inconsistent with nearby "$backupInstance" variables; this makes copy/paste examples harder to follow. Please rename it to "$backupInstanceCreate" (or similar) consistently.

Suggested change
$backupnstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject
$backupInstanceCreate = New-AzDataProtectionBackupInstance -ResourceGroupName "resourceGroupName" -VaultName "vaultName" -SubscriptionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -BackupInstance $backupInstanceClientObject

Copilot uses AI. Check for mistakes.
Comment on lines +120 to +121
This command is used to change CmkIdentityType from SystemAssigned to UserAssgined.
CmkIdenityId is a required parameter.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example description contains typos and refers to the wrong/unclear parameter name. "UserAssgined" should be "UserAssigned", and the required CMK identity parameter should match the actual cmdlet parameter name (CmkUserAssignedIdentityId).

Copilot uses AI. Check for mistakes.
Third command fetches the list of vaulted containers which are currently backed up in the backup vault.
Fourth command update the backup instance with new policy and new list of container (which is currently a subset of the existing backed up containers).
Fifth and sixth command shows the updated policy and containers list in the backup instance.
Fifth and sixth command shows the updated policy and containers list in the backu instance.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "backu" should be "backup".

Copilot uses AI. Check for mistakes.
The first command gets the default vaulted policy template for AzureBlob.
The second to fifteenth command defines and updates the Operational, vaulted weekly, monthly, yearly lifecycle and tagcriteria.
Next we define a trigger object with schedule time and timezone, set it to 2:30 AM West Europe standard time.
Next we define a trigger object with schedule time and timzone, set it to 2:30 AM West Europe standard time.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "timzone" should be "timezone".

Suggested change
Next we define a trigger object with schedule time and timzone, set it to 2:30 AM West Europe standard time.
Next we define a trigger object with schedule time and timezone, set it to 2:30 AM West Europe standard time.

Copilot uses AI. Check for mistakes.
Fetch the backup instance.
Fetch valid time ranges for Backup Instance $instance[0].
Display RestorableTimeRange, note that this can be multiple discrete ranges.
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "Dispaly" should be "Display".

Suggested change
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Display RestorableTimeRange, note that this can be multiple discrete ranges.

Copilot uses AI. Check for mistakes.
Fetch the backup instance.
Fetch valid time ranges for Backup Instance $instance[0].
Display RestorableTimeRange, note that this can be multiple discrete ranges.
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in help text: "dicrete" should be "discrete".

Suggested change
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Display RestorableTimeRange, note that this can be multiple discrete ranges.

Copilot uses AI. Check for mistakes.
@JunKai-v JunKai-v added Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Feb 3, 2026
@JunKai-v JunKai-v marked this pull request as ready for review February 3, 2026 05:24
@JunKai-v
Copy link
Author

JunKai-v commented Feb 4, 2026

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@JunKai-v JunKai-v requested a review from Pan-Qi February 5, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant