-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.Databricks] Update generation tool version: autorest.powershell v3->v4 #28554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
To the author of the pull request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure Databricks PowerShell module by upgrading the AutoRest PowerShell generation tool from version 3 to version 4. The update modernizes the code generation process and aligns with newer AutoRest standards while maintaining backward compatibility.
Key changes include:
- Upgrade from AutoRest PowerShell v3 to v4 for code generation
- Extensive parameter type updates from enum types to string types across cmdlets
- Breaking change exception configurations for maintaining API compatibility
- Test configuration updates and example corrections
Reviewed Changes
Copilot reviewed 45 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.Databricks/BreakingChangeIssues.csv | Adds comprehensive breaking change exceptions to maintain API compatibility during the tool upgrade |
| src/Databricks/Databricks/help/*.md | Updates help documentation with corrected parameter types and improved descriptions |
| src/Databricks/Databricks.Autorest/test/*.ps1 | Updates test cases to use new parameter syntax (switch parameters instead of boolean values) |
| src/Databricks/Databricks.Autorest/custom/*.ps1 | Refactors custom cmdlet implementations to use string types and new parameter sets |
| src/Databricks/Databricks.Autorest/README.md | Updates AutoRest configuration to remove v3-specific settings and directives |
Comments suppressed due to low confidence (6)
… jinpei/main/Databricks-v4
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Category('Body')] | ||
| [System.Boolean] | ||
| # [System.Management.Automation.SwitchParameter] | ||
| [System.Management.Automation.SwitchParameter] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change the type from boolean to switch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VeryEarly, this change in parameter type is due to the internals of Update-AzDatabricksVNetPeering. The AllowVirtualNetworkAccess parameter is defined as a SwitchParameter internally, so we're following the internal parameter type definition.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 47 out of 50 changed files in this pull request and generated 6 comments.
|
|
||
| ### -AutomaticClusterUpdate | ||
| Status of automated cluster updates feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for AutomaticClusterUpdate is over-simplified (just a period: "."). This should be replaced with a meaningful description explaining what the parameter does, such as "Status of automated cluster updates feature" or similar descriptive text that helps users understand the parameter's purpose.
|
|
||
| ### -EnhancedSecurityCompliance | ||
| Status of Compliance Security Profile feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for EnhancedSecurityCompliance is over-simplified (just a period: "."). This should be replaced with a meaningful description such as "Status of Compliance Security Profile feature" or similar descriptive text that helps users understand the parameter's purpose.
|
|
||
| ### -EnhancedSecurityMonitoring | ||
| Status of Enhanced Security Monitoring feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for EnhancedSecurityMonitoring is over-simplified (just a period: "."). This should be replaced with a meaningful description such as "Status of Enhanced Security Monitoring feature" or similar descriptive text that helps users understand the parameter's purpose.
|
|
||
| ### -AutomaticClusterUpdate | ||
| Status of automated cluster updates feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for AutomaticClusterUpdate is over-simplified (just a period: "."). This should be replaced with a meaningful description such as "Status of automated cluster updates feature" or similar descriptive text that helps users understand the parameter's purpose.
|
|
||
| ### -EnhancedSecurityCompliance | ||
| Status of Compliance Security Profile feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for EnhancedSecurityCompliance is over-simplified (just a period: "."). This should be replaced with a meaningful description such as "Status of Compliance Security Profile feature" or similar descriptive text that helps users understand the parameter's purpose.
|
|
||
| ### -EnhancedSecurityMonitoring | ||
| Status of Enhanced Security Monitoring feature. | ||
| . |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter description for EnhancedSecurityMonitoring is over-simplified (just a period: "."). This should be replaced with a meaningful description such as "Status of Enhanced Security Monitoring feature" or similar descriptive text that helps users understand the parameter's purpose.
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.