Skip to content

Conversation

@lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented Aug 27, 2025

#28572

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

…ing cmdlet adds a BreakingChange announcement
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Aug 27, 2025
@lijinpei2008 lijinpei2008 marked this pull request as ready for review September 2, 2025 09:57
Copilot AI review requested due to automatic review settings September 2, 2025 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds breaking change announcements for the Az.CloudService module in preparation for a future codebase refactoring that will change property types from arrays/objects to lists across multiple cmdlets.

  • Added breaking change announcements for 15 CloudService cmdlets in the ChangeLog
  • Updated module dependencies and configuration files for the AutoRest generation
  • Added OutputBreakingChange attributes to affected custom cmdlet implementations

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/CloudService/CloudService/ChangeLog.md Added breaking change announcement for 15 cmdlets changing from array/object to list types
src/CloudService/CloudService/Az.CloudService.psd1 Updated Az.Accounts dependency version and module configuration
src/CloudService/CloudService.sln Updated solution file with new project GUIDs and platform configurations
src/CloudService/CloudService.Autorest/README.md Added AutoRest breaking change directives for all affected cmdlets
src/CloudService/CloudService.Autorest/custom/*.ps1 Added OutputBreakingChange attributes to custom cmdlet implementations
src/CloudService/CloudService.Autorest/docs/Az.CloudService.md Updated module GUID
src/CloudService/CloudService.Autorest/generate-info.json Updated generation ID
src/CloudService/CloudService.Autorest/Properties/AssemblyInfo.cs Added new assembly information file
src/CloudService/CloudService.Autorest/resources/README.md Added new resources directory documentation

- Additional information about change #1
-->
## Upcoming Release
* Added breaking change announcement for below commands from array or object to list.
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'for below commands' is grammatically incorrect. It should be 'for the following commands' or 'for the commands below'.

Suggested change
* Added breaking change announcement for below commands from array or object to list.
* Added breaking change announcement for the following commands from array or object to list.

Copilot uses AI. Check for mistakes.
@VeryEarly VeryEarly self-assigned this Sep 4, 2025
@VeryEarly VeryEarly merged commit 863b4db into main Sep 4, 2025
12 checks passed
@VeryEarly VeryEarly deleted the jinpei/main/CloudService-Announcement branch September 4, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants