Skip to content

Conversation

@Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Jul 24, 2025

Description

Preannouncement PR:

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi force-pushed the bernard-migrate-websites-to-v4 branch from bf40356 to 345bc0f Compare July 30, 2025 14:36
@Pan-Qi Pan-Qi marked this pull request as ready for review August 6, 2025 13:51
Copilot AI review requested due to automatic review settings August 6, 2025 13:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Azure PowerShell Websites module to use AutoRest v4, introducing various new features and breaking changes.

  • Upgrades the code generator from AutoRest v3 to v4, bringing new parameter sets and parameter types
  • Updates cmdlet signatures, particularly for Static Web App cmdlets with new identity management parameters
  • Changes many API response models from versioned namespaces to unversioned interfaces

Reviewed Changes

Copilot reviewed 112 out of 112 changed files in this pull request and generated 1 comment.

File Description
tools/StaticAnalysis/Exceptions/Az.LoadTesting/BreakingChangeIssues.csv Documents breaking changes including type changes, removed parameters, and removed parameter sets
src/Websites/Websites/help/*.md Updates documentation for cmdlets with new parameter sets, type changes, and corrected descriptions
src/Websites/Websites/ChangeLog.md Documents the upgrade and breaking changes for New-AzStaticWebApp identity parameters
src/Websites/Websites/Az.Websites.psd1 Updates module metadata including required Az.Accounts version and file paths

### Example 2: Create or updates the app settings of a static site build by pipeline
```powershell
Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name staticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' }
Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' }
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the example: 'taticweb00' should be 'staticweb00' to match the expected static web app naming convention.

Suggested change
Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' }
Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name staticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' }

Copilot uses AI. Check for mistakes.
@Pan-Qi Pan-Qi added the Contains Breaking Change This PR contains breaking change label Aug 14, 2025
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@isra-fel isra-fel added the autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 label Oct 2, 2025
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@isra-fel isra-fel added this to the Az 16.0.0 (TBD) milestone Jan 29, 2026
@naveedaz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 28268 in repo Azure/azure-powershell

@naveedaz
Copy link
Contributor

@mishapos and @skylathadani-ms can you guys review too?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 112 out of 112 changed files in this pull request and generated 7 comments.

Comment on lines +69 to 70
Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' }
```
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example uses a likely typo in the static site name ("taticweb00"), which will cause copy/paste failures. Please correct it to the intended site name used elsewhere in the examples.

Copilot uses AI. Check for mistakes.
Comment on lines +11 to 12
Description for update a user entry with the listed roles

Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synopsis/description text is grammatically incorrect ("Description for update a user entry...") and reads like an unedited template. Please change it to a proper verb form (e.g., "Updates a user entry...") for the reference help.

Copilot uses AI. Check for mistakes.
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in the header comment: missing space after the period in "Code Generator.Changes". Please add the missing space to keep the generated header readable.

Suggested change
// Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code
// Code generated by Microsoft (R) AutoRest Code Generator. Changes may cause incorrect behavior and will be lost if the code

Copilot uses AI. Check for mistakes.
Comment on lines +330 to +333
Description for update a new static site in an existing resource group, or update an existing static site.

### [Update-AzStaticWebAppUser](Update-AzStaticWebAppUser.md)
Description for Updates a user entry with the listed roles
Description for update a user entry with the listed roles
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This synopsis line is grammatically incorrect and misleading ("update a new static site..."). Please adjust it to accurately describe the cmdlet (it updates an existing static site; it doesn't "update a new" one).

Copilot uses AI. Check for mistakes.
Comment on lines 55 to 57
# Modules that must be imported into the global environment prior to importing this module
RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '4.2.0'; })
RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '5.1.1'; })

Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module dependency versions are inconsistent across the Websites module artifacts: the manifest requires Az.Accounts 5.1.1, but the AutoRest README states 2.7.5+ and the .nuspec depends on 2.7.5. Please align these (and ensure the chosen minimum is reflected consistently in psd1, nuspec, and README) to avoid install/import mismatches for users.

Copilot uses AI. Check for mistakes.
- Additional information about change #1
-->
## Upcoming Release
* Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249).
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Upcoming Release entry is too generic for users and doesn't clearly describe the actual change (AutoRest v4 migration) or reference the related announcement PRs/issues. Please update the entry to explicitly state what's changing for Az.Websites users and include relevant issue/PR references.

Copilot uses AI. Check for mistakes.

### [New-AzStaticWebApp](New-AzStaticWebApp.md)
Description for Creates a new static site in an existing resource group, or updates an existing static site.
Description for create a new static site in an existing resource group, or create an existing static site.
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is grammatically incorrect and also changes the meaning: "or create an existing static site" should be "or update an existing static site". Please fix the synopsis/description text so it accurately reflects the cmdlet behavior.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants