-
Notifications
You must be signed in to change notification settings - Fork 4.1k
upgrade websites module to autorest v4 #28268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
bf40356 to
345bc0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Azure PowerShell Websites module to use AutoRest v4, introducing various new features and breaking changes.
- Upgrades the code generator from AutoRest v3 to v4, bringing new parameter sets and parameter types
- Updates cmdlet signatures, particularly for Static Web App cmdlets with new identity management parameters
- Changes many API response models from versioned namespaces to unversioned interfaces
Reviewed Changes
Copilot reviewed 112 out of 112 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.LoadTesting/BreakingChangeIssues.csv | Documents breaking changes including type changes, removed parameters, and removed parameter sets |
| src/Websites/Websites/help/*.md | Updates documentation for cmdlets with new parameter sets, type changes, and corrected descriptions |
| src/Websites/Websites/ChangeLog.md | Documents the upgrade and breaking changes for New-AzStaticWebApp identity parameters |
| src/Websites/Websites/Az.Websites.psd1 | Updates module metadata including required Az.Accounts version and file paths |
| ### Example 2: Create or updates the app settings of a static site build by pipeline | ||
| ```powershell | ||
| Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name staticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' } | ||
| Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' } |
Copilot
AI
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the example: 'taticweb00' should be 'staticweb00' to match the expected static web app naming convention.
| Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' } | |
| Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name staticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' } |
|
To the author of the pull request, |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28268 in repo Azure/azure-powershell |
|
@mishapos and @skylathadani-ms can you guys review too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 112 out of 112 changed files in this pull request and generated 7 comments.
| Get-AzStaticWebAppBuildAppSetting -ResourceGroupName resourceGroup -Name taticweb00 -EnvironmentName 'default' | New-AzStaticWebAppBuildAppSetting -AppSetting @{'buildsetting1' = 'someval'; 'buildsetting2' = 'someval2' } | ||
| ``` |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example uses a likely typo in the static site name ("taticweb00"), which will cause copy/paste failures. Please correct it to the intended site name used elsewhere in the examples.
| Description for update a user entry with the listed roles | ||
|
|
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The synopsis/description text is grammatically incorrect ("Description for update a user entry...") and reads like an unedited template. Please change it to a proper verb form (e.g., "Updates a user entry...") for the reference help.
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo in the header comment: missing space after the period in "Code Generator.Changes". Please add the missing space to keep the generated header readable.
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | |
| // Code generated by Microsoft (R) AutoRest Code Generator. Changes may cause incorrect behavior and will be lost if the code |
| Description for update a new static site in an existing resource group, or update an existing static site. | ||
|
|
||
| ### [Update-AzStaticWebAppUser](Update-AzStaticWebAppUser.md) | ||
| Description for Updates a user entry with the listed roles | ||
| Description for update a user entry with the listed roles |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This synopsis line is grammatically incorrect and misleading ("update a new static site..."). Please adjust it to accurately describe the cmdlet (it updates an existing static site; it doesn't "update a new" one).
| # Modules that must be imported into the global environment prior to importing this module | ||
| RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '4.2.0'; }) | ||
| RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '5.1.1'; }) | ||
|
|
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module dependency versions are inconsistent across the Websites module artifacts: the manifest requires Az.Accounts 5.1.1, but the AutoRest README states 2.7.5+ and the .nuspec depends on 2.7.5. Please align these (and ensure the chosen minimum is reflected consistently in psd1, nuspec, and README) to avoid install/import mismatches for users.
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249). |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Upcoming Release entry is too generic for users and doesn't clearly describe the actual change (AutoRest v4 migration) or reference the related announcement PRs/issues. Please update the entry to explicitly state what's changing for Az.Websites users and include relevant issue/PR references.
|
|
||
| ### [New-AzStaticWebApp](New-AzStaticWebApp.md) | ||
| Description for Creates a new static site in an existing resource group, or updates an existing static site. | ||
| Description for create a new static site in an existing resource group, or create an existing static site. |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is grammatically incorrect and also changes the meaning: "or create an existing static site" should be "or update an existing static site". Please fix the synopsis/description text so it accurately reflects the cmdlet behavior.
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.