Skip to content

[Az.PurviewData] update generation tool version: autorest.powershell v3 -> v4 #27946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

lijinpei2008
Copy link
Contributor

The service team failed to provide a valid unit test, please ignore the items related to testing.
The content of the changelog is consistent with the PR shared below, so it will be updated in the PR below:
#27871

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 marked this pull request as ready for review June 12, 2025 11:54
@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 11:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the autorest.powershell generator from v3 to v4, which resulted in refreshed help markdown, updated parameter types, online URLs, model namespaces, and the addition of new Update-* cmdlets in the module manifest and solution.

  • Revamped help files for numerous cmdlets: removed legacy -Kind entries, changed enum types to String/String[], adjusted online URLs, and updated output model namespaces
  • Updated Az.Purview.md to refine cmdlet summaries and appended Update-* cmdlets at the end
  • Bumped the generated date in Az.Purview.psd1, exported new Update-* cmdlets, and synchronized the solution (.sln) with new project GUIDs

Reviewed Changes

Copilot reviewed 482 out of 482 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md Dropped -Kind parameter from syntax/example; updated types/URLs
src/Purview/Purview/help/New-AzPurviewAdlsGen1MsiScanObject.md Removed -Kind; changed types to String
src/Purview/Purview/help/New-AzPurviewAdlsGen1DataSourceObject.md Omitted -Kind; adjusted types
src/Purview/Purview/help/New-AzPurviewAdlsGen1CredentialScanObject.md Removed -Kind; updated types
src/Purview/Purview/help/Invoke-AzPurviewTagClassificationRuleClassificationVersion.md Changed -Action type from enum to String
src/Purview/Purview/help/Get-AzPurviewTrigger.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewSystemScanRulesetVersion.md Changed -DataSourceType to String; updated output model
src/Purview/Purview/help/Get-AzPurviewSystemScanRulesetLatest.md Same as above
src/Purview/Purview/help/Get-AzPurviewSystemScanRuleset.md Same as above
src/Purview/Purview/help/Get-AzPurviewScanRuleset.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewScanResultScanHistory.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewScan.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewKeyVaultConnection.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewFilter.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewDataSource.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewClassificationRuleVersion.md Updated output model namespace
src/Purview/Purview/help/Get-AzPurviewClassificationRule.md Updated output model namespace
src/Purview/Purview/help/Az.Purview.md Refined cmdlet descriptions; appended new Update-* entries
src/Purview/Purview/Az.Purview.psd1 Updated generated date; exported new Update-* cmdlets
src/Purview/Purview.sln Realigned projects; added Purviewdata.Autorest & Az.Purviewdata
Comments suppressed due to low confidence (4)

src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md:15

  • The required -Kind parameter is missing from the syntax and example but is still mandatory for the cmdlet; please reintroduce -Kind <DataSourceType> in both the syntax block and example.
New-AzPurviewAdlsGen1ScanRulesetObject [-Description <String>] [-ExcludedSystemClassification <String[]>] ...

src/Purview/Purview/help/New-AzPurviewAdlsGen1MsiScanObject.md:15

  • The mandatory -Kind parameter has been removed from the syntax and example but remains required by the cmdlet signature; please restore it.
New-AzPurviewAdlsGen1MsiScanObject [-CollectionReferenceName <String>] ...

src/Purview/Purview/help/New-AzPurviewAdlsGen1DataSourceObject.md:15

  • Documentation for the -Kind parameter has been omitted, though the cmdlet still requires it; please add -Kind <DataSourceType> back into the syntax and examples.
New-AzPurviewAdlsGen1DataSourceObject [-CollectionReferenceName <String>] ...

src/Purview/Purview/help/New-AzPurviewAdlsGen1CredentialScanObject.md:15

  • The -Kind parameter section was removed but is still required; please reinstate -Kind <ScanAuthorizationType> in syntax and example.
New-AzPurviewAdlsGen1CredentialScanObject [-CollectionReferenceName <String>] ...

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit 095fd27 into main Jun 13, 2025
13 checks passed
@lijinpei2008 lijinpei2008 deleted the jinpei/main/PurviewData-v4 branch June 13, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants