-
Notifications
You must be signed in to change notification settings - Fork 4k
[StorageAction] First GA release, updated per latest swagger #27928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Autorest-generated test recordings and PowerShell tests to align with the GA release and latest Swagger:
- Standardizes URIs to use the new subscription, resource group, and
eastus2
location. - Updates response headers (status codes, ETags, async operation URLs) in the recording JSONs.
- Loosens the report-count assertion in
Get-AzStorageActionTasksReport.Tests.ps1
to allow zero results.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/StorageAction/StorageAction.Autorest/test/*.Recording.json | Updated subscription IDs, endpoints, HTTP statuses, headers, and response bodies to match GA responses. |
src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1 | Changed Should -BeGreaterThan 1 to Should -BeGreaterOrEqual 0 with explanatory comment. |
src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1.bak | Added backup file; likely unintentional. |
Comments suppressed due to low confidence (1)
src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1.bak:1
- The
.bak
file appears to be a backup of the test script and should not be committed. Please remove this file or add it to.gitignore
to avoid confusion.
if(($null -eq $TestName) -or ($TestName -contains 'Get-AzStorageActionTasksReport'))
@@ -14,7 +14,7 @@ Lists Resource IDs of the Storage Task Assignments associated with this Storage | |||
|
|||
``` | |||
Get-AzStorageActionTaskAssignment -ResourceGroupName <String> -StorageTaskName <String> | |||
[-SubscriptionId <String[]>] [-Maxpagesize <String>] [-DefaultProfile <PSObject>] [<CommonParameters>] | |||
[-SubscriptionId <String[]>] [-Maxpagesize <Int32>] [-DefaultProfile <PSObject>] [<CommonParameters>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use MaxPageSize to follow the naming convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is autogen code.
Would you please check with Xiaogang if this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blueww You can leverage directives to rename the parameter. Please refer to https://github.com/Azure/autorest.powershell/blob/main/docs/directives.md#Parameter-Rename.
src/StorageAction/StorageAction.Autorest/docs/Update-AzStorageActionTask.md
Show resolved
Hide resolved
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
This feature is already public preview, plan to GA it on 7/1.
The PSH API almost has not change, just update per latest swagger and record test cases.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.