Skip to content

[StorageAction] First GA release, updated per latest swagger #27928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blueww
Copy link
Member

@blueww blueww commented Jun 11, 2025

Description

This feature is already public preview, plan to GA it on 7/1.
The PSH API almost has not change, just update per latest swagger and record test cases.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 08:22
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Autorest-generated test recordings and PowerShell tests to align with the GA release and latest Swagger:

  • Standardizes URIs to use the new subscription, resource group, and eastus2 location.
  • Updates response headers (status codes, ETags, async operation URLs) in the recording JSONs.
  • Loosens the report-count assertion in Get-AzStorageActionTasksReport.Tests.ps1 to allow zero results.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

File Description
src/StorageAction/StorageAction.Autorest/test/*.Recording.json Updated subscription IDs, endpoints, HTTP statuses, headers, and response bodies to match GA responses.
src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1 Changed Should -BeGreaterThan 1 to Should -BeGreaterOrEqual 0 with explanatory comment.
src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1.bak Added backup file; likely unintentional.
Comments suppressed due to low confidence (1)

src/StorageAction/StorageAction.Autorest/test/Get-AzStorageActionTasksReport.Tests.ps1.bak:1

  • The .bak file appears to be a backup of the test script and should not be committed. Please remove this file or add it to .gitignore to avoid confusion.
if(($null -eq $TestName) -or ($TestName -contains 'Get-AzStorageActionTasksReport'))

@blueww blueww force-pushed the StorageActionGA branch from 4733e5f to 34e730d Compare June 11, 2025 08:25
@@ -14,7 +14,7 @@ Lists Resource IDs of the Storage Task Assignments associated with this Storage

```
Get-AzStorageActionTaskAssignment -ResourceGroupName <String> -StorageTaskName <String>
[-SubscriptionId <String[]>] [-Maxpagesize <String>] [-DefaultProfile <PSObject>] [<CommonParameters>]
[-SubscriptionId <String[]>] [-Maxpagesize <Int32>] [-DefaultProfile <PSObject>] [<CommonParameters>]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to use MaxPageSize to follow the naming convention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogen code.
Would you please check with Xiaogang if this is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww You can leverage directives to rename the parameter. Please refer to https://github.com/Azure/autorest.powershell/blob/main/docs/directives.md#Parameter-Rename.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants