-
Notifications
You must be signed in to change notification settings - Fork 4k
Add new cmdlets for AzureDataTransfer #27926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Cmdlet design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1490 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds full documentation and UX definitions for new AzureDataTransfer cmdlets, along with module scaffolding and assembly info.
- Generated markdown help for all new cmdlets (Approve, Deny, Invoke-Link, Get, Enable/Disable flows, etc.).
- Added UX JSON definitions for pipelines and connections commands.
- Updated custom module loader script and AssemblyInfo.
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Invoke-AzDataTransferLinkPendingConnection.md | Documentation for Invoke-AzDataTransferLinkPendingConnection . |
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Approve-AzDataTransferConnection.md | Documentation for Approve-AzDataTransferConnection . |
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Deny-AzDataTransferConnection.md | Documentation for Deny-AzDataTransferConnection . |
Comments suppressed due to low confidence (2)
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Deny-AzDataTransferConnection.md:64
- [nitpick] The example uses pipelineName 'corptest', which doesn't match the preceding variable or typical naming; consider using 'Pipeline01' for consistency.
Deny-AzDataTransferConnection -PipelineName corptest -ResourceGroupName ResourceGroup01 -ConnectionId $connectionToDeny.Id -StatusReason "Not Authorized for processing" -Confirm:$false
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Invoke-AzDataTransferLinkPendingConnection.md:18
- [nitpick] Consider updating
-SubscriptionId
to accept an array (String[]
) to match other cmdlets and support multiple subscriptions.
-PendingConnectionId <String> [-SubscriptionId <String>] [-StatusReason <String>]
src/AzureDataTransfer/AzureDataTransfer.Autorest/docs/Approve-AzDataTransferConnection.md
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@fzkhan Please upload the generate-info.json file to fix the build issue. |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@vidai-msft I was following this wiki to generate the cmdlets and it did not output a On the same note, I see a comment in the wiki that says:
Is that also a file we have to add manually? So far, the only file I have added on my own is the |
The generate-info.json is generated by running build-module.ps1. If you do not see the file, please upgrade your autorest.powershell version to get the new feature. |
I updated to the latest version. But still not getting any additional files. Here is the
Ran |
Can you share the detailed steps? |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.