-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding generated code for FIST 2024-04-01-preview api #27912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds generated code for the 2024-04-01-preview API for FirmwareAnalysis, updating documentation and auto-generated configuration files.
- Updated the ChangeLog.md to announce the new preview release (version 0.2.0).
- Updated AutoRest configuration in README.md to reference the new preview input file and commit id.
- Added new resource and examples documentation files, and a new AssemblyInfo.cs with metadata.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/FirmwareAnalysis/FirmwareAnalysis/ChangeLog.md | Added new release note for version 0.2.0 |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/resources/README.md | Added resource guidance documentation |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/generate-info.json | Removed obsolete generate-info.json content |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/examples/README.md | Added examples documentation |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/README.md | Updated AutoRest configuration with new commit id and input file for preview API |
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/Properties/AssemblyInfo.cs | Added new AssemblyInfo with assembly attributes |
Comments suppressed due to low confidence (1)
src/FirmwareAnalysis/FirmwareAnalysis.Autorest/Properties/AssemblyInfo.cs:23
- The assembly version in AssemblyInfo.cs is still set to 0.1.0.0, which is inconsistent with the new release version 0.2.0 indicated in the ChangeLog.md. Consider updating the version attributes to avoid confusion for consumers.
[assembly: System.Reflection.AssemblyFileVersionAttribute("0.1.0.0")]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate-info.json cannot be removed. Please submit all the generated files as well. Otherwise, it would cause issues.
In addition, can you please confirm there is no cmdlet change with API version update?
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Adding generated code from the 2024-04-01-preview API for FirmwareAnalysis
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.