Skip to content

Enabled setting ssh auth scope in environment #27878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Jun 2, 2025

Description

Enabled setting ssh auth scope in environment.
Pending on Azure/azure-powershell-common#447

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@isra-fel isra-fel marked this pull request as ready for review June 3, 2025 01:19
@Copilot Copilot AI review requested due to automatic review settings June 3, 2025 01:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables setting the SSH authentication scope in the Azure environment configuration.

  • Updates package dependency versions from 1.3.108-preview to 1.3.109-preview.
  • Introduces a new error resource and updates SSH credential handling to check for the SSH authentication scope.
  • Modifies cmdlets and help documentation to include the new -SshAuthScope parameter.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/Common.Netcore.Dependencies.targets Bumped dependency versions and updated the corresponding StorageToolsPath.
src/Accounts/Authentication/Properties/Resources.resx Added a new error message resource for missing SSH auth scope.
src/Accounts/Authentication/Factories/SshCredentialFactory.cs Added a case-insensitive dictionary and refactored authentication scope lookup.
src/Accounts/Accounts/help/Set-AzEnvironment.md, Add-AzEnvironment.md, Az.Accounts.md Updated help documentation to include the new -SshAuthScope parameter.
src/Accounts/Accounts/Environment/SetAzureRMEnvironment.cs, AddAzureRMEnvironment.cs Added support to set the AzureSshAuthScope endpoint via the new parameter.
src/Accounts/Accounts/ChangeLog.md Updated change log with the new SSH authentication scope feature.
Files not reviewed (1)
  • src/Accounts/Authentication/Properties/Resources.Designer.cs: Language not supported

private string GetAuthScope(IAzureEnvironment environment)
{
return environment.GetProperty(AzureEnvironment.ExtendedEndpoint.AzureSshAuthScope)
?? CloudToScope.GetValueOrDefault(environment.Name.ToLower(), null);
Copy link
Preview

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the CloudToScope dictionary now uses StringComparer.InvariantCultureIgnoreCase, converting environment.Name to lower case is unnecessary and could be removed for clarity.

Suggested change
?? CloudToScope.GetValueOrDefault(environment.Name.ToLower(), null);
?? CloudToScope.GetValueOrDefault(environment.Name, null);

Copilot uses AI. Check for mistakes.

@msJinLei msJinLei merged commit c690c21 into main Jun 3, 2025
12 checks passed
@isra-fel isra-fel deleted the yeming/ssh-scope branch June 3, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants