-
Notifications
You must be signed in to change notification settings - Fork 4k
PSH comdlets for MongoDB initial release #27833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the initial release of PowerShell cmdlets for MongoDB by adding various auto‐generated files, tests, documentation, examples, and custom implementations. Key changes include the addition of test recordings (JSON), new test scripts and examples for cmdlets (e.g. New‑AzMongoDBOrganization, Get‑AzMongoDBOrganization, Remove‑AzMongoDBOrganization), and expanded module documentation and build scripts.
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/MongoDB/MongoDB.Autorest/test/New-AzMongoDBOrganization.Recording.json | Recorded HTTP interactions for creating a MongoDB organization resource. |
src/MongoDB/MongoDB.Autorest/test/Get-AzMongoDBOrganization.Tests.ps1 | Test script for Get‑AzMongoDBOrganization cmdlet with basic functional validation. |
src/MongoDB/MongoDB.Autorest/test/Get-AzMongoDBOrganization.Recording.json | Recorded HTTP interactions for retrieving MongoDB organizations. |
src/MongoDB/MongoDB.Autorest/resources/README.md | Additional resources file outlining usage for non-runtime assets. |
src/MongoDB/MongoDB.Autorest/how-to.md | Developer guidance for building, testing, and packaging the module. |
(Other docs, examples, custom scripts, and configuration files) | Various supporting files to facilitate cmdlet generation, custom cmdlets, and module packaging. |
Comments suppressed due to low confidence (1)
src/MongoDB/MongoDB.Autorest/test/Get-AzMongoDBOrganization.Tests.ps1:18
- [nitpick] The current test only verifies that some results are returned; adding scenarios for error cases or invalid inputs could improve test coverage and robustness of the cmdlet.
It 'Get' {
. ($loadEnvPath) | ||
$TestRecordingFile = Join-Path $PSScriptRoot 'Get-AzMongoDBOrganization.Recording.json' | ||
$currentPath = $PSScriptRoot | ||
while(-not $mockingPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider initializing $mockingPath (e.g. set $mockingPath = $null) before the while loop and adding a termination condition (such as checking if $currentPath becomes empty) to avoid a potential infinite loop if 'HttpPipelineMocking.ps1' is not found.
while(-not $mockingPath) { | |
$mockingPath = $null | |
while(-not $mockingPath -and $currentPath) { |
Copilot uses AI. Check for mistakes.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.