Skip to content

[Eng] Fix parameterset name in publish-rmmodule #27814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/ModulePublisher.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ function Publish-RMModules
$RepoLocation,

[Parameter(ParameterSetName="ByLocation", Mandatory=$true)]
[Parameter(ParameterSetName="ByLocation", Mandatory=$false)]
[Parameter(ParameterSetName="ByName", Mandatory=$false)]
Copy link
Preview

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Since parameters default to non-mandatory, you can omit Mandatory=$false here to reduce redundancy and clarify that $ApiKey is optional in this set.

Suggested change
[Parameter(ParameterSetName="ByName", Mandatory=$false)]
[Parameter(ParameterSetName="ByName")]

Copilot uses AI. Check for mistakes.

[string]
$ApiKey,

Expand Down
Loading