-
Notifications
You must be signed in to change notification settings - Fork 4k
Added Support to Input Multiple User Assigned Identities #27750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Thank you for your contribution @Balashivaram! We will review the pull request and get back to you soon. |
generated/Monitor/PipelineGroup.Autorest/Az.PipelineGroup.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the src/Network/Network/ChangeLog.md
and put your messages right under the Upcoming Release
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
|
||
[Parameter( | ||
Mandatory = false, | ||
HelpMessage = "Firewall Policy Identity to be assigned to Firewall Policy.")] | ||
[ValidateNotNullOrEmpty] | ||
public PSManagedServiceIdentity Identity { get; set; } | ||
|
||
[Parameter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove the a parameter is a breaking change, which can only be release in the major release. The next one is in November.
@Balashivaram You can split the PR into breaking change commit and non-breaking change commit

@Balashivaram please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
To the author of the pull request, |
Description
Azure Firewall team has made newer changes to feature Explicit Proxy. Explicit Proxy feature is already in Public Preview but the new changes will change the customer experience in using the Explicit Proxy feature. Due to this Explicit Proxy newer version is releasing again in Public preview and the new changes are added behind Feature Flag in all three places (Portal, Control Plane and Data Plane) and the new changes will be called by name Explicit Proxy V2. In Explicit Proxy V2 Version, removed HTTPs Port, instead of PAC File SAS URL customer needs to give PAC File URL with a managed identity which will have required roles to access the file
In the current PR to support Explicit Proxy V2 version, we have removed HTTPs Port Input, instead of PAC File SAS URL we will be getting PAC File URL as a input and a user Assigned Identity. Since Explicit Proxy is supported in Standard SKU, identity object has been removed from Premium property and customer can input multiple User Assigned Identities to support this User Assigned Identity parameter has been changes from String to Array of Strings
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.