Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HealthDeid from generation to main #26414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azure-pipelines[bot]
Copy link
Contributor

Description

Migrate HealthDeid from generation to main
The last commit of src/HealthDeid in generation is:
commit 0b68ced Author: alexathomases 55257302+alexathomases@users.noreply.github.com Date: Mon Oct 21 23:45:40 2024 -0700 Creating cmdlets for Health Deidentification (GA) (#26409) * 2024-09-20 version * Setting up tests * Tests with preview version * Test improvements, still WIP * Tests passing * Created examples and documentation * Revert whitespace change * Revert changes to Policy.Autorest * Remove sample JSON from docs * Rm sample JSON in examples --------- Co-authored-by: Alexa Thomases athomases@microsoft.com

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Oct 22, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.HealthDeid
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzHealthDeidPrivateLink Get-AzHealthDeidPrivateLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzHealthDeidPrivateLink Get-AzHealthDeidPrivateLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzHealthDeidService Get-AzHealthDeidService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzHealthDeidService Get-AzHealthDeidService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzHealthDeidPrivateLink Get-AzHealthDeidPrivateLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzHealthDeidPrivateLink Get-AzHealthDeidPrivateLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzHealthDeidService Get-AzHealthDeidService Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzHealthDeidService Get-AzHealthDeidService changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Get-AzHealthDeidPrivateLink 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Get-AzHealthDeidPrivateLink 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid.Autorest\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add title for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add code for the example. Remove any placeholders.
Get-AzHealthDeidPrivateLink 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\HealthDeid\HealthDeid\help\Get-AzHealthDeidPrivateLink.md Add description for the example. Remove any placeholders.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants