-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ExlucdeFromLatest field to TargetRegion parameter New/Update-AzGalleryImageVersion #24531
Conversation
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
please review/merge @Nickcandy |
src/Compute/Compute/ChangeLog.md
Outdated
@@ -32,6 +32,7 @@ | |||
`Get-AzVmss` will no longer allow empty values to `ResourceGroupName` and `VMScaleSetName` to avoid a bug where it will just return nothing. | |||
* Added a new parameter `-SharingProfile` to `New-AzCapacityReservationGroup` and `Update-AzCapacityReservationGroup`. | |||
* Added the new parameter `SourceImageVMId` to the `New-AzGalleryImageVersion` cmdlet. Also added some error messages for this new parameter and the existing parameter `SourceImageId`. | |||
* Parameter `-TargetRegion` in `New-AzGalleryImageVersion` and `Update-AzGalleryImageVersion` will now accept `ExcludeFromLatest` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rephrase this sentence in the past tense, like the other changelog entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -125,6 +125,7 @@ public override void ExecuteCmdlet() | |||
Name = (string)t["Name"], | |||
RegionalReplicaCount = (int?)t["ReplicaCount"], | |||
StorageAccountType = (string)t["StorageAccountType"], | |||
ExcludeFromLatest = (bool?)t["ExcludeFromLatest"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add test in these files: https://github.com/Azure/azure-powershell/tree/main/src/Compute/Compute/Generated/GalleryImageVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@Nickcandy i've addressed your comments. will you review merge ? |
@grizzlytheodore Sure, it looks good to me and let's wait for the ci check |
@Nickcandy CI looks good! |
Description
Updating Bug: https://msazure.visualstudio.com/One/_workitems/edit/26504946
ICM: https://portal.microsofticm.com/imp/v5/incidents/details/459937637/summary
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.