add ExlucdeFromLatest field to TargetRegion parameter New/Update-AzGalleryImageVersion #24531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grizzlytheodore
requested review from
bilaakpan-ms,
Sandido and
haagha
as code owners
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
|
Testing Results: |
|
please review/merge @Nickcandy |
Nickcandy
reviewed
Apr 4, 2024
src/Compute/Compute/ChangeLog.md
Outdated
| @@ -32,6 +32,7 @@ | |||
| `Get-AzVmss` will no longer allow empty values to `ResourceGroupName` and `VMScaleSetName` to avoid a bug where it will just return nothing. | |||
| * Added a new parameter `-SharingProfile` to `New-AzCapacityReservationGroup` and `Update-AzCapacityReservationGroup`. | |||
| * Added the new parameter `SourceImageVMId` to the `New-AzGalleryImageVersion` cmdlet. Also added some error messages for this new parameter and the existing parameter `SourceImageId`. | |||
| * Parameter `-TargetRegion` in `New-AzGalleryImageVersion` and `Update-AzGalleryImageVersion` will now accept `ExcludeFromLatest` field. | |||
There was a problem hiding this comment.
Please rephrase this sentence in the past tense, like the other changelog entries.
Nickcandy
reviewed
Apr 4, 2024
| @@ -125,6 +125,7 @@ public override void ExecuteCmdlet() | |||
| Name = (string)t["Name"], | |||
| RegionalReplicaCount = (int?)t["ReplicaCount"], | |||
| StorageAccountType = (string)t["StorageAccountType"], | |||
| ExcludeFromLatest = (bool?)t["ExcludeFromLatest"], | |||
There was a problem hiding this comment.
Could you add test in these files: https://github.com/Azure/azure-powershell/tree/main/src/Compute/Compute/Generated/GalleryImageVersion
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
@Nickcandy i've addressed your comments. will you review merge ? |
|
@grizzlytheodore Sure, it looks good to me and let's wait for the ci check |
|
@Nickcandy CI looks good! |
Nickcandy
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating Bug: https://msazure.visualstudio.com/One/_workitems/edit/26504946
ICM: https://portal.microsofticm.com/imp/v5/incidents/details/459937637/summary
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.