Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.Resources] Add 2 tests for roleassignment #23874

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[Az.Resources] Add 2 tests for roleassignment #23874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void RaByResource()
}

[Fact]//(Skip = "Test indicates Graph call is not recorded when it actually is, refer to https://github.com/Azure/azure-powershell/issues/14632 for more details, test passes in record mode")]
[Trait(Category.AcceptanceType, Category.LiveOnly)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void RaByServicePrincipal()
{
TestRunner.RunTestScript("Test-RaByServicePrincipal");
Expand Down Expand Up @@ -155,7 +155,7 @@ public void RaGetByUPNWithExpandPrincipalGroups()
}

[Fact]
[Trait(Category.AcceptanceType, Category.LiveOnly)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void RaCreatedBySP()
{
TestRunner.RunTestScript("Test-RaCreatedBySP");
Expand Down
17 changes: 8 additions & 9 deletions src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,18 +241,18 @@ Tests verifies creation and deletion of a RoleAssignments for Service principal
function Test-RaByServicePrincipal
{
# Setup
$servicePrincipals = "7059a716-3bd8-405e-ac54-4fe098aba140" # powershell-test-uami
$servicePrincipals = "3d9979c5-7de9-4cc5-bc9c-d63d365c5b5c"

$definitionName = 'Reader'
$Scope = '/subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f'
$Scope = '/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590'

# Test
$newAssignment1 = New-AzRoleAssignment -ObjectId $servicePrincipals -RoleDefinitionName $definitionName -Scope $scope
$newAssignment1 = New-AzRoleAssignmentWithId -ObjectId $servicePrincipals -RoleDefinitionName $definitionName -Scope $scope -RoleAssignmentId 238799bf-1a93-45d7-120d-f3edbaeb3bc7

$definitionName = 'Contributor'
# Test
$appId = "306d85f9-f885-4bdf-a20e-36d6ee8eddad" # PowershellTestingApp
$newAssignment2 = New-AzRoleAssignment -ApplicationId $appId -RoleDefinitionName $definitionName -Scope $scope
$appId = "2076eb2d-7a68-41f8-9645-4a77d9057d94"
$newAssignment2 = New-AzRoleAssignmentWithId -ApplicationId $appId -RoleDefinitionName $definitionName -Scope $scope -RoleAssignmentId 238799bf-1593-45d7-120d-f3edbceb3bc7

$assignments = Get-AzRoleAssignment -ObjectId $newAssignment2.ObjectId
Assert-NotNull $assignments
Expand All @@ -267,7 +267,6 @@ function Test-RaByServicePrincipal
Assert-NotNull $newAssignment2
Assert-AreEqual $definitionName $newAssignment2.RoleDefinitionName
Assert-AreEqual $scope $newAssignment2.Scope
# Assert-AreEqual $servicePrincipals[0].DisplayName $newAssignment2.DisplayName

#Start-TestSleep -Seconds 300

Expand Down Expand Up @@ -622,10 +621,10 @@ function Test-RaCreatedBySP
# Prerequisite: Conect to azure with SP
# Create role assignment
# powershell-testmember's PrincipalId
$testUser = "e9da4467-12ff-4334-8179-c99abf0ffd5a"
$Scope = '/subscriptions/4004a9fd-d58e-48dc-aeb2-4a4aec58606f'
$testUser = "3d9979c5-7de9-4cc5-bc9c-d63d365c5b5c"
$Scope = '/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590'

$assignment = New-AzRoleAssignment -ObjectId $testUser -RoleDefinitionName 'Reader' -Scope $Scope
$assignment = New-AzRoleAssignmentWithId -ObjectId $testUser -RoleDefinitionName 'Reader' -Scope $Scope -RoleAssignmentId 3d9979c5-7de9-4cc5-bc9c-d63d365c5b44

Assert-NotNull $assignment
}
Expand Down
Loading