Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instance Pool API version to Preview 2023-05-01 and PS cmdlets #23336

Conversation

MilanNz
Copy link
Contributor

@MilanNz MilanNz commented Nov 9, 2023

Description

In the new review API 2023-05-01, we have introduced new parameters in the SQL Instance Pool resource. Since the new API has been released, I am updating existing Instance Pool PowerShell cmdlets with these changes.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Nov 9, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@MilanNz MilanNz changed the title Update Instance Pool API version to Preview 2023-05-01 Update Instance Pool API version to Preview 2023-05-01 and PS cmdlets Nov 9, 2023
@VeryEarly
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly merged commit 4133dec into Azure:main Nov 10, 2023
14 checks passed
VeryEarly added a commit that referenced this pull request Nov 10, 2023
* Sync resourceManagement.yml (#23294)

* Changed default selection to prevent inaccuracies (#23313)

Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>

* update TestLiveScenarios.ps1 (#23304)

* Display cmdlet, parameter set and parameter level coverage data for a module (#23327)

* General Availability of Az.Tools.Installer (#23323)

* Migration Guide of Az 11.0.0 (#23328)

* Try to Generate Migration Guide

* Update documentation/migration-guides/Az.11.0.0-migration-guide.md

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* [DataFacotry]Added support copyComputeScale And pipelineExternalComputeScale in Set-AzDataFactoryV2IntegrationRuntime Command (#23321)

* [DataFacotry]Added support copyComputeScale And pipelineExternalComputeScale in Set-AzDataFactoryV2IntegrationRuntime Command

* fix

* change

* fix

* Update ChangeLog.md

---------

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Update Instance Pool API version to Preview 2023-05-01 (#23336)

Co-authored-by: Milan Adamovic <madamovic@microsoft.com>

---------

Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Mike F. Robbins <mike.robbins@microsoft.com>
Co-authored-by: Mike F. Robbins <mikefrobbins@users.noreply.github.com>
Co-authored-by: lijinpei2008 <31384087+lijinpei2008@users.noreply.github.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com>
Co-authored-by: Milan Adamovic <madamovic.bg@gmail.com>
Co-authored-by: Milan Adamovic <madamovic@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants