Skip to content

[Redis] Add support for 2022-06-01 API version #20511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 5, 2023
Merged

[Redis] Add support for 2022-06-01 API version #20511

merged 26 commits into from
Jan 5, 2023

Conversation

austintolani
Copy link
Contributor

Description

This PR adds supports for a new API version for Azure Cache for Redis (2022-06-01). Specifically, these changes include:

  • Upgrading Microsoft.Azure.Management.Redis package to new version 9.0.0, which updates all requests to use the new 2022-06-01 API version. Notably this package is updated to use a private NuGet feed, since this is a Track 1 SDK and is no longer being updated publicly.
  • Import-AzRedisCache and Export-AzRedisCache has a new optional parameter PreferredDataArchiveAuthMethod.
  • Linked server deletion (Remove-AzRedisCacheLink) is now a long running operation, so its implementation now calls BeginDelete() instead of Delete().
  • Updating a cache (Set-AzRedisCache) is now a long running operation so its implementation now calls BeginUpdate() instead of Update().
  • Get-AzRedisCacheLink and New-AzRedisCacheLink will show 4 additional properties for a geo replication link: PrimaryHostName, GeoReplicatedPrimaryHostName, ServerRole and LinkedRedisCacheLocation.
  • Relevant updates to help documentation
  • Relevant updates to tests

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@austintolani
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 20511 in repo Azure/azure-powershell

@austintolani
Copy link
Contributor Author

@msJinLei I have been trying to get the pipelines to pass but am facing issues. The tests are passing on my local machine but it seems like there is some environment issue causing differing behavior between my local environment and the pipelines.

We would like for these changes to go out in the Jan release. Would it be possible for you to review this PR while I continue to try to solve the pipeline issues so that when they pass we will able to merge it in in time for the Jan release?

@austintolani
Copy link
Contributor Author

@msJinLei All pipelines are now passing. As mentioned in previous comment, we would like for these changes to go out in the Jan release. Please let me know if there are any additional steps I can take on my end with this PR. Thanks!

dingmeng-xue
dingmeng-xue previously approved these changes Jan 4, 2023
@dingmeng-xue dingmeng-xue changed the base branch from main to release-2023-01-10 January 4, 2023 03:17
@dingmeng-xue dingmeng-xue dismissed their stale review January 4, 2023 03:17

The base branch was changed.

@dingmeng-xue dingmeng-xue changed the base branch from release-2023-01-10 to main January 4, 2023 03:18
@dingmeng-xue dingmeng-xue changed the base branch from main to release-2023-01-10 January 4, 2023 03:18
@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants