[#114730201][#114888193] Automation for selecting subscription and tenant in authentication scenarios #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 14, 2016 16:05
haocs
changed the title
| @@ -121,8 +121,16 @@ public RMProfileClient(AzureRMProfile profile) | |||
| newTenant == null && | |||
| TryGetTenantSubscription(token, account, environment, tenant, subscriptionId, subscriptionName, out tempSubscription, out tempTenant)) | |||
| { | |||
| newTenant = tempTenant; | |||
| newSubscription = tempSubscription; | |||
| if (tempSubscription == null && i + 1 < tenants.Count()) | |||
There was a problem hiding this comment.
No need for the empty bock. You can invert the if to work for one case. Doesn't this work?
If( tempSubscription != null || i == (tenants.Count() -1) )
There was a problem hiding this comment.
BTW, this will change the logic of selecting the tenants. Now if tenant does not have any subscription - Last tenant will be selected. Somewhere in the code we say that "First subscription will be selected"
There was a problem hiding this comment.
- yes.
- To keep the tenant selecting order, how about iterating tenants in a reverse fashion? Personally, I don't think "first tenant/subscription" makes much sense here if tenants are not sorted(or sorted alphabetically).
|
@azuresdkci add to whitelist |
hovsepm
pushed a commit
that referenced
this pull request
Mar 16, 2016
[#114730201][#114888193] Automation for selecting subscription and tenant in authentication scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.