Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator "Any" in New-AzApplicationGatewayFirewallCondition #18458

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Add operator "Any" in New-AzApplicationGatewayFirewallCondition #18458

merged 3 commits into from
Jun 17, 2022

Conversation

AdishreeM
Copy link
Contributor

Description

Add operator "Any" in New-AzApplicationGatewayFirewallCondition

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jun 13, 2022
@VeryEarly
Copy link
Contributor

please fix failed test case: ApplicationGatewayTests.ps1: line 2450

@amazumder-msft
Add operator "Any" in New-AzApplicationGatewayFirewallCondition
3769e6d 
* Added "Any" to FirewallCondition's Operator ValidateSet

* Updated validation since MatchValue isn't required for "Any"

* Added scenario test
@amazumder-msft
Adding sessionRecord file
be1a056
@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 6fa0e2c into Azure:network-2022-01-01 Jun 17, 2022
@AdishreeM AdishreeM mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdishreeM @VeryEarly @amazumder-msft