Skip to content

Dev #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Dev #184

wants to merge 12 commits into from

Conversation

chadiel
Copy link
Contributor

@chadiel chadiel commented Feb 20, 2015

Adds the following cmdlets:

Get-AzureProvider
Register-AzureProvider
Unregister-AzureProvider
Get-AzureProviderFeature
Register-AzureProviderFeature

Shadi M. El Hajj Sleiman added 3 commits February 11, 2015 20:17
Conflicts:
	src/Common/Commands.Common.Storage/packages.config
	src/Common/Commands.Common.Test/packages.config
	src/Common/Commands.Common/packages.config
	src/Common/Commands.Profile/packages.config
	src/Common/Commands.ScenarioTest/packages.config
	src/Common/Commands.ScenarioTests.Common/packages.config
	src/ResourceManager/Batch/Commands.Batch.Test/packages.config
	src/ResourceManager/DataFactories/Commands.DataFactories.Test/packages.config
	src/ResourceManager/DataFactories/Commands.DataFactories/packages.config
	src/ResourceManager/Insights/Commands.Insights.Test/Commands.Insights.Test.csproj
	src/ResourceManager/Insights/Commands.Insights.Test/packages.config
	src/ResourceManager/Insights/Commands.Insights/Commands.Insights.csproj
	src/ResourceManager/Insights/Commands.Insights/packages.config
	src/ResourceManager/KeyVault/Commands.KeyVault.Test/packages.config
	src/ResourceManager/KeyVault/Commands.KeyVault/packages.config
	src/ResourceManager/RedisCache/Commands.RedisCache.Test/packages.config
	src/ResourceManager/Resources/Commands.Resources.Test/packages.config
	src/ResourceManager/Resources/Commands.Resources/Models.ResourceGroups/ResourceClient.cs
	src/ResourceManager/Resources/Commands.Resources/Models.ResourceGroups/ResourcesBaseCmdlet.cs
	src/ResourceManager/Sql/Commands.Sql/packages.config
	src/ResourceManager/StreamAnalytics/Commands.StreamAnalytics/packages.config
	src/ResourceManager/Tags/Commands.Tags/packages.config
	src/ServiceManagement/Automation/Commands.Automation.Test/packages.config
	src/ServiceManagement/Automation/Commands.Automation/packages.config
	src/ServiceManagement/Compute/Commands.ServiceManagement.Extensions.Test/packages.config
	src/ServiceManagement/Compute/Commands.ServiceManagement.PlatformImageRepository/packages.config
	src/ServiceManagement/Compute/Commands.ServiceManagement.Preview/packages.config
	src/ServiceManagement/Compute/Commands.ServiceManagement.Test/packages.config
	src/ServiceManagement/Compute/Commands.ServiceManagement/packages.config
	src/ServiceManagement/ExpressRoute/Commands.ExpressRoute/packages.config
	src/ServiceManagement/HDInsight/Commands.HDInsight.Test/packages.config
	src/ServiceManagement/HDInsight/Commands.HDInsight/packages.config
	src/ServiceManagement/ManagedCache/Commands.ManagedCache.Test/packages.config
	src/ServiceManagement/ManagedCache/Commands.ManagedCache/packages.config
	src/ServiceManagement/Network/Commands.Network.Test/packages.config
	src/ServiceManagement/Network/Commands.Network/packages.config
	src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/packages.config
	src/ServiceManagement/Services/Commands.Test.Utilities/packages.config
	src/ServiceManagement/Services/Commands.Test/packages.config
	src/ServiceManagement/Services/Commands.Utilities/packages.config
	src/ServiceManagement/Services/Commands/packages.config
	src/ServiceManagement/Sql/Commands.SqlDatabase.Test/packages.config
	src/ServiceManagement/Sql/Commands.SqlDatabase/packages.config
	src/ServiceManagement/StorSimple/Commands.StorSimple.Test/packages.config
	src/ServiceManagement/StorSimple/Commands.StorSimple/Commands.StorSimple.csproj
	src/ServiceManagement/StorSimple/Commands.StorSimple/packages.config
	src/ServiceManagement/Storage/Commands.Storage.Test/packages.config
	src/ServiceManagement/Storage/Commands.Storage/packages.config
	src/ServiceManagement/TrafficManager/Commands.TrafficManager.Test/packages.config
	src/ServiceManagement/TrafficManager/Commands.TrafficManager/packages.config
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @chadiel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (chadiel). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@amarzavery
Copy link
Contributor

@chadiel please pull from upstream dev and resolve merge conflicts

@chadiel
Copy link
Contributor Author

chadiel commented Feb 20, 2015

I did before sending the CR – am I missing something?

C:\GitHub\chadiel\azure-powershell
$> git merge upstream/dev
Already up-to-date.

C:\GitHub\chadiel\azure-powershell
$> git pull
Already up-to-date.

C:\GitHub\chadiel\azure-powershell
$>

Thanks,

Shadi Majed El Hajj Sleiman
Sr. Software Eng Mgr | Cloud & Enterprise – Modern Apps – Azure Resource Manager (Sparta)
Microsoft Corporation | One Microsoft Way, Redmond WA 98052
shadi.sleiman@microsoft.commailto:shadi.slieman@microsoft.com | Office: +1 (425) 421 8218

From: amarzavery [mailto:notifications@github.com]
Sent: Friday, February 20, 2015 10:32 AM
To: Azure/azure-powershell
Cc: Shadi M. El Hajj Sleiman
Subject: Re: [azure-powershell] Dev (#184)

@chadielhttps://github.com/chadiel please pull from upstream dev and resolve merge conflicts


Reply to this email directly or view it on GitHubhttps://github.com//pull/184#issuecomment-75293656.

@ogail
Copy link
Contributor

ogail commented Feb 20, 2015

@chadiel do git pull upstream dev that should make it

Conflicts:
	src/ServiceManagement/StorSimple/Commands.StorSimple.Test/App.config
@chadiel
Copy link
Contributor Author

chadiel commented Feb 21, 2015

Done

From: Abdelrahman Elogeel [mailto:notifications@github.com]
Sent: Friday, February 20, 2015 3:30 PM
To: Azure/azure-powershell
Cc: Shadi M. El Hajj Sleiman
Subject: Re: [azure-powershell] Dev (#184)

@chadielhttps://github.com/chadiel do git pull upstream dev that should make it


Reply to this email directly or view it on GitHubhttps://github.com//pull/184#issuecomment-75338705.

@ogail
Copy link
Contributor

ogail commented Feb 21, 2015

@azuresdkci add to whitelist

@@ -166,6 +165,7 @@
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<None Include="app.config" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove app.config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chadiel
Copy link
Contributor Author

chadiel commented Feb 23, 2015

Updated the CR and addressed all comments - could you please review and merge this pull request?

@chadiel chadiel closed this Feb 23, 2015
@chadiel chadiel reopened this Feb 24, 2015
@azurecla
Copy link

Hi @chadiel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (chadiel). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@chadiel
Copy link
Contributor Author

chadiel commented Feb 24, 2015

Addressed all CR comments - please review

@chadiel
Copy link
Contributor Author

chadiel commented Feb 24, 2015

Seems like the merge job has a bug in it? It fails w/ access denied...

Deleting project workspace... Cannot delete workspace: remote file operation failed: D:/workspace/azure-powershell at hudson.remoting.Channel@1e3d2b3:slave-1: java.nio.file.AccessDeniedException: D:\workspace\azure-powershell\src\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.Tasks.dll
ERROR: Cannot delete workspace: remote file operation failed: D:/workspace/azure-powershell at hudson.remoting.Channel@1e3d2b3:slave-1: java.nio.file.AccessDeniedException: D:\workspace\azure-powershell\src\packages\Microsoft.Bcl.Build.1.0.14\tools\Microsoft.Bcl.Build.Tasks.dll
[ANALYSIS-COLLECTOR] Skipping publisher since build result is FAILURE
Archiving artifacts

@ogail
Copy link
Contributor

ogail commented Feb 25, 2015

@chadiel the PR still have merge conflicts

Shadi M. El Hajj Sleiman added 2 commits February 25, 2015 10:26
Conflicts:
	src/ServiceManagement/RecoveryServices/Commands.RecoveryServices.Test/packages.config
	src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/packages.config
@chadiel chadiel closed this Feb 26, 2015
AzureRT referenced this pull request in AzureRT/azure-powershell Nov 11, 2015
markcowl pushed a commit that referenced this pull request Apr 28, 2016
Jobs base and IaaSVM DCs and basic translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants