Changed RemoteDebuggingVersion from string type to enum and added tests. #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haocs
changed the title
|
|
||
| Set-AzureWebsite $name -Slot Production -SiteWithConfig $website | ||
| Assert-AreEqual $true $website.RemoteDebuggingEnabled | ||
| Assert-AreEqual $remotedebuggingversion $website.RemoteDebuggingVersion |
|
@haocs you will need to pull from upstream dev. On-Demand job failed due to the issue that is already fixed in dev. |
|
@hovsepm on-demand job passed http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/535/ |
| @@ -63,7 +63,7 @@ public interface ISiteConfig | |||
|
|
|||
| bool? RemoteDebuggingEnabled { get; set; } | |||
|
|
|||
| RemoteDebuggingVersion RemoteDebuggingVersion { get; set; } | |||
There was a problem hiding this comment.
Is the type "RemoteDebugginVersion" used anywhere stil? If not we should delete the type.
There was a problem hiding this comment.
It has string constants with the known values now, it's not used elsewhere or compilation would have failed.
|
Looks good. |
|
Approved |
markcowl
added a commit
that referenced
this pull request
Feb 25, 2016
Changed RemoteDebuggingVersion from string type to enum and added tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.