Skip to content

[Storage] show oauth token in debug log in debug build only #17986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Upcoming Release
* Show OAuth token in debug log in debug build only
- `New-AzStorageContext`

## Version 4.5.0
* Supported DaysAfterLastTierChangeGreaterThan in Management Policy
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/Common/AzureSessionCredential.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,12 @@ public override AccessToken GetToken(TokenRequestContext requestContext, Cancell
{
token = new AccessToken(tokenValue, DateTimeOffset.UtcNow);
});
#if DEBUG
if (this.debugLogWriter != null)
{
this.debugLogWriter("[" + DateTime.Now.ToString() + "] GetToken: " + token.Token);
}
#endif
return token;
}

Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/Common/Cmdlet/NewAzureStorageContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,9 @@ private string GetTokenStrFromAccessToken(IAccessToken accessToken)
{
tokenStr = tokenValue;
});
#if DEBUG
WriteDebug(DateTime.Now.ToString() + ": token:" + tokenStr);
#endif
return tokenStr;
}

Expand Down