Skip to content

Edited New-AzVm to ensure the PlatformFaultDomain parameter in the VmConfig object is used #17859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2022

Conversation

Sandido
Copy link
Contributor

@Sandido Sandido commented Apr 19, 2022

Description

This bug was made showing that if a user was creating a VM attached to a Vmss with a VMConfig object, and the VM has a PlatformFaultDomain value, the PFD value was not put onto the created VM.
Looks like the cause of this was because the original feature release for PFD did not include code for the PFD value in the parameter set where a VMConfig object is used.

No changes to any customer facing values, only internal business logic of the cmdlet.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@isra-fel isra-fel self-assigned this Apr 20, 2022
Copy link
Member

@grizzlytheodore grizzlytheodore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if I am understanding the title/example correctly. Isnt your code in NewAzureVMCommand.cs adding it for when PlatformFaultDomain is provided from New-AzConfig, not New-AzVmssConfig?

@Sandido Sandido changed the title Edited New-AzVm to ensure the PlatformFaultDomain parameter in the VmssConfig object is used Edited New-AzVm to ensure the PlatformFaultDomain parameter in the VmConfig object is used Apr 21, 2022
@Sandido
Copy link
Contributor Author

Sandido commented Apr 21, 2022

i'm not sure if I am understanding the title/example correctly. Isnt your code in NewAzureVMCommand.cs adding it for when PlatformFaultDomain is provided from New-AzConfig, not New-AzVmssConfig?

Yes! I edited the title.

to avoid bad merge
format example
isra-fel
isra-fel previously approved these changes Apr 22, 2022
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyunchi-ms wyunchi-ms merged commit a238f79 into main Apr 25, 2022
@wyunchi-ms wyunchi-ms deleted the adsandor/pfdbugvm branch May 24, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants