-
Notifications
You must be signed in to change notification settings - Fork 4k
Edited New-AzVm to ensure the PlatformFaultDomain parameter in the VmConfig object is used #17859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if I am understanding the title/example correctly. Isnt your code in NewAzureVMCommand.cs adding it for when PlatformFaultDomain is provided from New-AzConfig, not New-AzVmssConfig?
Yes! I edited the title. |
to avoid bad merge
format example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This bug was made showing that if a user was creating a VM attached to a Vmss with a VMConfig object, and the VM has a PlatformFaultDomain value, the PFD value was not put onto the created VM.
Looks like the cause of this was because the original feature release for PFD did not include code for the PFD value in the parameter set where a VMConfig object is used.
No changes to any customer facing values, only internal business logic of the cmdlet.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added