Fix Az.PrivateDNS Syntax Errors #17749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyuezh576
previously approved these changes
Apr 15, 2022
isra-fel
requested changes
Apr 21, 2022
| @@ -142,13 +142,13 @@ This example adds a CNAME record to an existing record set. | |||
|
|
|||
| ### Example 4: Add a MX record to a record set | |||
| ```powershell | |||
| $RecordSet = Get-AzPrivateDnsRecordSet -Name @ -RecordType MX -ResourceGroupName MyResourceGroup -ZoneName myzone.com | |||
There was a problem hiding this comment.
"@" is a valid name. It just needs to be quoted though "@"
| $Zone = Get-AzPrivateDnsZone -Name "myzone.com" -ResourceGroupName "MyResourceGroup" | ||
| $RecordSets = Get-AzPrivateDnsRecordSet -Zone $Zone | ||
| $Zone = Get-AzPrivateDnsZone -Name "myzone.com" -ResourceGroupName "MyResourceGroup" | ||
| $RecordSets = Get-AzPrivateDnsRecordSet -Zone $Zone |
There was a problem hiding this comment.
If an example has output, it should not assign the result to a variable, because by assigning the value there will be no output.
Suggested change
| $RecordSets = Get-AzPrivateDnsRecordSet -Zone $Zone | |
| Get-AzPrivateDnsRecordSet -Zone $Zone |
There was a problem hiding this comment.
Can we detect this issue automatically?
There was a problem hiding this comment.
Our current code can not detect this problem.
isra-fel
reviewed
Apr 27, 2022
isra-fel
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added