Fix Az.KeyVault Syntax Errors #17601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyuezh576
suggested changes
Mar 30, 2022
| Update-AzKeyVaultSecret -VaultName 'ContosoVault' -Name 'HR' -Version '9EEA45C6EE50490B9C3176A80AC1A0DF' -ContentType '' -Tag -@{} | ||
| $Tags = @{ 'Severity' = 'medium'; 'HR' = 'true'} | ||
| $ContentType= 'xml' | ||
| Update-AzKeyVaultSecret -VaultName 'ContosoVault' -Name 'HR' -Version '9EEA45C6EE50490B9C3176A80AC1A0DF' -ContentType $ContentType -Tag $Tags |
There was a problem hiding this comment.
-Tag @{} (delete the dash before @)
No other errors here. The purpose of this command is to delete, so blank value is assigned.
isra-fel
requested changes
Mar 31, 2022
| @@ -33,7 +33,7 @@ Exports the security domain data of a managed HSM for importing on another HSM. | |||
|
|
|||
| ### Example 1 | |||
| ```powershell | |||
| Export-AzKeyVaultSecurityDomain -Name testmhsm -Certificates {pathOfCertificates}/sd1.cer, {pathOfCertificates}/sd2.cer, {pathOfCertificates}/sd3.cer -OutputPath {pathOfOutput}/sd.ps.json -Quorum 2 | |||
| Export-AzKeyVaultSecurityDomain -Name testmhsm -Certificates {{pathOfCertificates}/sd1.cer, {pathOfCertificates}/sd2.cer, {pathOfCertificates}/sd3.cer} -OutputPath {{pathOfOutput}/sd.ps.json} -Quorum 2 | |||
There was a problem hiding this comment.
In the original example, {} is not powershell gramma. It means that pathOfCertificates is a placeholder that user needs to replace with the real path.
If {} made our tooling think the example is wrong, I suggest replace {pathOfCertificates}/sd1.cer to ./sd1, and {pathOfOutput}/sd.ps.json to sd.ps.json.
There was a problem hiding this comment.
Thanks. We will do that.
| @@ -34,7 +34,7 @@ This cmdlet imports previously exported security domain data to a managed HSM. | |||
| ### Example 1 | |||
| ```powershell | |||
| $keys = @{PublicKey = "sd1.cer"; PrivateKey = "sd1.key"}, @{PublicKey = "sd2.cer"; PrivateKey = "sd2.key"}, @{PublicKey = "sd3.cer"; PrivateKey = "sd3.key"} | |||
| Import-AzKeyVaultSecurityDomain -Name testmhsm -Keys $keys -SecurityDomainPath {pathOfBackup}\sd.ps.json | |||
| Import-AzKeyVaultSecurityDomain -Name testmhsm -Keys $keys -SecurityDomainPath {{pathOfBackup}\sd.ps.json} | |||
Comment on lines
66
to
68
| $Tags = @{ 'Severity' = 'medium'; 'HR' = 'true'} | ||
| $ContentType= 'xml' | ||
| Update-AzKeyVaultSecret -VaultName 'ContosoVault' -Name 'HR' -Version '9EEA45C6EE50490B9C3176A80AC1A0DF' -ContentType $ContentType -Tag $Tags |
There was a problem hiding this comment.
Suggested change
| $Tags = @{ 'Severity' = 'medium'; 'HR' = 'true'} | |
| $ContentType= 'xml' | |
| Update-AzKeyVaultSecret -VaultName 'ContosoVault' -Name 'HR' -Version '9EEA45C6EE50490B9C3176A80AC1A0DF' -ContentType $ContentType -Tag $Tags | |
| $ContentType= 'xml' | |
| Update-AzKeyVaultSecret -VaultName 'ContosoVault' -Name 'HR' -Version '9EEA45C6EE50490B9C3176A80AC1A0DF' -ContentType $ContentType -Tag @{} |
ziyuezh576
approved these changes
Apr 2, 2022
isra-fel
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added