-
Notifications
You must be signed in to change notification settings - Fork 4k
Azure Logic App PowerShell Cmdlets #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with Installer and PowerShell help included.
Cmdlets Help Installer Changes Test Automation ps1xml Output Format Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>
# Conflicts: # setup/azurecmdfiles.wxi # src/ResourceManager/LogicApp/Commands.LogicApp.Test/Commands.LogicApp.Test.csproj # src/ResourceManager/LogicApp/Commands.LogicApp.Test/UnitTests/CreateLogicAppTests.cs # src/ResourceManager/LogicApp/Commands.LogicApp.Test/packages.config # src/ResourceManager/LogicApp/Commands.LogicApp/Commands.LogicApp.csproj # src/ResourceManager/LogicApp/Commands.LogicApp/packages.config # src/ResourceManager/LogicApp/LogicApp.sln
Removed App.config in Test project Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>
Signed-off-by: Pankaj Singh Negi <pankaj.negi@microsoft.com>
Can one of the admins verify this patch? |
Hi @pankajsn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
@azuresdkci add to whitelist |
# Conflicts: # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowAccessKeyTests/TestGetAzureLogicAppAccessKey.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowAccessKeyTests/TestSetAzureLogicAppAccessKey.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestGetAzureLogicAppRunAction.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestGetAzureLogicAppRunHistory.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowRunTests/TestRunLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateAndGetLogicAppUsingDefinitionWithActions.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateAndRemoveLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingDefinitionWithTriggers.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingInputParameterAsHashTable.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppUsingInputfromWorkflowObject.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppWithDuplicateName.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestCreateLogicAppWithNonExistingAppServicePlan.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestRemoveNonExistingLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTests/TestUpdateLogicApp.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestGetAzureLogicAppTrigger.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestGetAzureLogicAppTriggerHistory.json # src/ResourceManager/LogicApp/Commands.LogicApp.Test/SessionRecords/Microsoft.Azure.Commands.LogicApp.Test.ScenarioTests.WorkflowTriggerTests/TestStartAzureLogicAppTrigger.json
azurecmdfiles.wxi file got messed up during merge. File is fixed and committed now. |
Updated Readme.md and ChangeLog.md with cmdlets description.
AzurePowerShell.Test.targets updated for test integration. |
@@ -119,6 +119,11 @@ This repository contains a set of PowerShell cmdlets for developers and administ | |||
* Azure Automation | |||
* Manage automation accounts | |||
* Manage automation jobs, runbooks and schedules | |||
* Logic Apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove, we are no longer updating the README for new RPs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Fixed] : Section removed from the Readme.md
From: Mark Cowlishaw [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 1:56 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Pankaj Singh Negi Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)
In README.mdhttps://github.com//pull/1753#discussion_r51487428:
@@ -119,6 +119,11 @@ This repository contains a set of PowerShell cmdlets for developers and administ
- Azure Automation
- Manage automation accounts
- Manage automation jobs, runbooks and schedules
+* Logic Apps
Please remove, we are no longer updating the README for new RPs
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753/files#r51487428.
AzureRM.Profile version corrected to 1.0.3 Removed content from Readme.md Removed unused reference from Test Project AssemblyInfo added
* Start-AzureLogicApp | ||
* Set-AzureLogicAppAccessKey | ||
* Set-AzureLogicApp | ||
* Stop-AzureLogicAppRun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes will not go out as part of February release. Please add a new tag
2016.03.08 version 1.3.0
and then add your change log text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Fixed]: Moved to new section as suggested. Below tag indicates next release in March. I just want to know, What is the process if we want to release these changes early?
From: Hovsep [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 3:22 PM
To: Azure/azure-powershell azure-powershell@noreply.github.com
Cc: Pankaj Singh Negi Pankaj.Negi@microsoft.com
Subject: Re: [azure-powershell] Azure Logic App PowerShell Cmdlets (#1753)
In ChangeLog.mdhttps://github.com//pull/1753#discussion_r51498279:
@@ -1,5 +1,18 @@
2016.02.02 version 1.1.1
- Azure RemoteApp: Organizational Unit in Azure RemoteApp RDFE cmdlets now accepts Unicode characters.
+* Azure LogicApp: New cmdlets for managing LogicApps
- Get-AzureLogicAppAccessKey
- Get-AzureLogicApp
- Get-AzureLogicAppRunAction
- Get-AzureLogicAppRunHistory
- Get-AzureLogicAppTrigger
- Get-AzureLogicAppTriggerHistory
- New-AzureLogicApp
- Remove-AzureLogicApp
- Start-AzureLogicApp
- Set-AzureLogicAppAccessKey
- Set-AzureLogicApp
- Stop-AzureLogicAppRun
Your changes will not go out as part of February release. Please add a new tag
2016.03.08 version 1.3.0
and then add your change log text.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1753/files#r51498279.
@pankajsn all the cmdlet names should follow [Verb]-AzureRM[prefix][noun] naming. Please fix. |
-Cmdlet name fixed as per naming convention -Assembly version fixed -snk file removed from test -ChangeLog.md file updated
[Fixed] Get-AzureLogicAppAccessKey >> Get-AzureRmLogicAppAccessKey From: Hovsep [mailto:notifications@github.com] @pankajsnhttps://github.com/pankajsn all the cmdlet names should follow [Verb]-AzureRM[prefix][noun] naming. Please fix. — |
Yes, Detailed cmdlet help is in place. Regards, Sent from my Windows Phone From: Trevor Sullivanmailto:notifications@github.com @pankajsnhttps://github.com/pankajsn @hovsepmhttps://github.com/hovsepm Thanks for ensuring naming standards. Are we also ensuring that there is detailed cmdlet help before they are released, please? Cheers, — |
@pankajsn Please pull from upstream dev and resolve conflicts. |
Conflicts: ChangeLog.md setup/azurecmdfiles.wxi
Conflicts: setup/azurecmdfiles.wxi
Removed InternalvisibleTo attribute as not needed
Azure Logic App PowerShell Cmdlets
This pull request contains the Azure Logic App PowerShell Cmdlets implementation which introduces following cmdlets:
Stop-AzureLogicAppRun
Get-AzureLogicAppAccessKey
Get-AzureLogicApp
Get-AzureLogicAppRunAction
Get-AzureLogicAppRunHistory
Get-AzureLogicAppTrigger
Get-AzureLogicAppTriggerHistory
New-AzureLogicApp
Remove-AzureLogicApp
Start-AzureLogicApp
Set-AzureLogicAppAccessKey
Set-AzureLogicApp
Also, includes: Test Automation, Installer Setup Update, Help Documentation, ps1xml