Skip to content

[OperationalInsights] bug fix ,added exception info returned and extended documentation file #16765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dabenhamMic
Copy link
Contributor

…eName'Heartbeat1_CL, Heartbeat1_CL'

the values which will be passed will be -TableNameHeartbeat1_CL and Heartbeat1_CL'
added extended error message when ErrorResponseException is thrown

Description

the positional argument of TableName that caused a bug:
whenever passing -TableName'Heartbeat1_CL, Heartbeat2_CL' (no space between -TableName and the actual value)
the values which will be passed are -TableNameHeartbeat1_CL and Heartbeat2_CL instead of Heartbeat1_CL and Heartbeat2_CL

whenever an exception is thrown from OperationalInsightsClient the error message returned to the client is missing the reason phrase returned from backend - now fixed

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…eName'Heartbeat1_CL, Heartbeat1_CL'

the values which will be passed will be -TableNameHeartbeat1_CL and Heartbeat1_CL'
added extended error message when ErrorResponseException is thrown
@wyunchi-ms
Copy link
Contributor

Please fix the static analysis exceptions.

@dabenhamMic
Copy link
Contributor Author

dabenhamMic commented Jan 6, 2022

@wyunchi-ms

I am not sure how to solve this issue.
the only fix made to this file is a bug fix - as mentioned in the PR description.

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dabenhamMic
Copy link
Contributor Author

@wyunchi-ms, also adding @yossi-y for visibility.
the removal of positional argument is needed from our end (the change you reverted), we found that in some cases if there is no space separating "-TableName" and the value itself, the value which is passed is the entire string
(for example -TableNameHeartbeat1_CL this issue can cause us some problems so we opt for removing it.
what can we do to remove this after all?

@wyunchi-ms wyunchi-ms merged commit 62607fa into Azure:main Jan 9, 2022
@dabenhamMic dabenhamMic added this to the Feb 2022 (2022-03-01) milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants