Issue #16094 - Updated New-AzAppServicePlan to create an app service plan with host environment id. #16645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlin-msft-zz
force-pushed
the
websites-dev
branch
4 times, most recently
from
ff361eb to
a8af780
Compare
madsd
suggested changes
Jan 3, 2022
| @@ -52,6 +52,9 @@ public static class CmdletHelpers | |||
| private static readonly Regex KeyVaultResourceIdRegex = | |||
| new Regex(@"^\/subscriptions\/(?<subscriptionName>[^\/]+)\/resourceGroups\/(?<resourceGroupName>[^\/]+)\/providers\/Microsoft.KeyVault\/vaults\/(?<vaultName>[^\/]+)$", RegexOptions.IgnoreCase); | |||
|
|
|||
| private static readonly Regex HostingEnvironmentResourceIdRegex = | |||
There was a problem hiding this comment.
Lets keep the AppServiceEnvironment naming consistent instead of HostingEnvironment (of course except when needed for ARM naming)
| @@ -269,6 +272,24 @@ internal static string BuildMetricFilter(DateTime? startTime, DateTime? endTime, | |||
| return false; | |||
| } | |||
|
|
|||
| internal static bool TryParseHostingEnvironmentMetadataFromResourceId(string resourceId, out string resourceGroupName, | |||
| internal static bool TryParseHostingEnvironmentMetadataFromResourceId(string resourceId, out string resourceGroupName, | ||
| out string aseName) | ||
| { | ||
| var match = AppServicePlanResourceIdRegex.Match(resourceId); |
There was a problem hiding this comment.
Wrong RegEx object, so it actually never succeeds.
| public SwitchParameter Linux { get; set; } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| if (HyperV.IsPresent && | ||
| if (HyperV.IsPresent && | ||
| (Tier != "PremiumContainer" && Tier != "PremiumV3")) |
There was a problem hiding this comment.
HyperV is also allowed for ASEv3, so please add: && Tier != "IsolatedV2"
and modify the exception text.
samlin-msft-zz
force-pushed
the
websites-dev
branch
from
a8af780 to
74970df
Compare
samlin-msft-zz
force-pushed
the
websites-dev
branch
from
74970df to
8f55247
Compare
added 2 commits
January 11, 2022 20:49
…ith host environment id (Azure#16094)
…e plan with host environment id (Azure#16094)
madsd
approved these changes
Jan 11, 2022
wyunchi-ms
approved these changes
Jan 17, 2022
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added