Skip to content

add 'platformFaultDomainCount' to New-AzVM/New-AzVMConfig #16625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Compute/Compute/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@

-->
## Upcoming Release
* Changed `New-AzVM` cmdlet when using the SimpleParameterSet to not create a PublicIPAddress when a PublicIPAddress name is not provided.
* Add `PlatformFaultDomain` parameter to cmdlets: `New-AzVM` and `New-AzVMConfig`
* Added `-Feature` parameter for `New-AzGalleryImageDefinition`
* Changed New-AzVm cmdlet when using the SimpleParameterSet to not create a PublicIPAddress when a PUblicIPAddress name is not provided.

## Version 4.21.0
* Contains updates to the following powershell cmdlets
Expand Down
2 changes: 2 additions & 0 deletions src/Compute/Compute/Models/PSVirtualMachine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -138,5 +138,7 @@ public string ResourceGroupName
public string UserData { get; set; }

public PSApplicationProfile ApplicationProfile { get; set; }

public int? PlatformFaultDomain { get; set; }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,12 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
double? maxPrice,
bool encryptionAtHostPresent,
List<SshPublicKey> sshPublicKeys,
int? platformFaultDomain = null,
string networkInterfaceDeleteOption = null,
string osDiskDeleteOption = null,
string dataDiskDeleteOption = null,
string userData = null)
string userData = null
)

=> Strategy.CreateResourceConfig(
resourceGroup: resourceGroup,
Expand Down Expand Up @@ -116,7 +118,8 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
{
CapacityReservationGroup = new SubResource(capacityReservationGroupId)
},
UserData = userData
UserData = userData,
PlatformFaultDomain = platformFaultDomain
});

public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
Expand All @@ -140,6 +143,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
string evictionPolicy,
double? maxPrice,
bool encryptionAtHostPresent,
int? platformFaultDomain,
string networkInterfaceDeleteOption = null,
string osDiskDeleteOption = null,
string dataDiskDeleteOption = null,
Expand Down Expand Up @@ -189,7 +193,8 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
{
CapacityReservationGroup = new SubResource(capacityReservationGroupId)
},
UserData = userData
UserData = userData,
PlatformFaultDomain = platformFaultDomain
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ protected override bool IsUsageMetricEnabled
ValueFromPipeline = true)]
public string UserData { get; set; }

[Parameter(
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "Specifies the fault domain of the virtual machine.")]
public int PlatformFaultDomain { get; set; }

public override void ExecuteCmdlet()
{
var vm = new PSVirtualMachine
Expand Down Expand Up @@ -241,6 +247,11 @@ public override void ExecuteCmdlet()
vm.UserData = this.UserData;
}

if (this.IsParameterBound(c => c.PlatformFaultDomain))
{
vm.PlatformFaultDomain = this.PlatformFaultDomain;
}

WriteObject(vm);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,18 @@ public class NewAzureVMCommand : VirtualMachineBaseCmdlet
ValueFromPipeline = true)]
public string UserData { get; set; }

[Parameter(
ParameterSetName = SimpleParameterSet,
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "Specifies the fault domain of the virtual machine.")]
[Parameter(
ParameterSetName = DiskFileParameterSet,
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "Specifies the fault domain of the virtual machine.")]
public int PlatformFaultDomain { get; set; }

public override void ExecuteCmdlet()
{
if (this.IsParameterBound(c => c.UserData))
Expand Down Expand Up @@ -517,7 +529,8 @@ public async Task<ResourceConfig<VirtualMachine>> CreateConfigAsync()
networkInterfaceDeleteOption: _cmdlet.NetworkInterfaceDeleteOption,
osDiskDeleteOption: _cmdlet.OSDiskDeleteOption,
dataDiskDeleteOption: _cmdlet.DataDiskDeleteOption,
userData: _cmdlet.UserData
userData: _cmdlet.UserData,
platformFaultDomain: _cmdlet.IsParameterBound(c => c.PlatformFaultDomain) ? _cmdlet.PlatformFaultDomain : (int?) null
);
}
else
Expand Down Expand Up @@ -549,7 +562,8 @@ public async Task<ResourceConfig<VirtualMachine>> CreateConfigAsync()
networkInterfaceDeleteOption: _cmdlet.NetworkInterfaceDeleteOption,
osDiskDeleteOption: _cmdlet.OSDiskDeleteOption,
dataDiskDeleteOption: _cmdlet.DataDiskDeleteOption,
userData: _cmdlet.UserData
userData: _cmdlet.UserData,
platformFaultDomain: _cmdlet.IsParameterBound(c => c.PlatformFaultDomain) ? _cmdlet.PlatformFaultDomain : (int?)null
);
}
}
Expand Down
21 changes: 19 additions & 2 deletions src/Compute/Compute/help/New-AzVM.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ New-AzVM [[-ResourceGroupName] <String>] [[-Location] <String>] [-EdgeZone <Stri
[-EnableUltraSSD] [-ProximityPlacementGroupId <String>] [-HostId <String>] [-VmssId <String>]
[-Priority <String>] [-EvictionPolicy <String>] [-MaxPrice <Double>] [-EncryptionAtHost]
[-HostGroupId <String>] [-SshKeyName <String>] [-GenerateSshKey] [-CapacityReservationGroupId <String>]
[-UserData <String>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
[-UserData <String>] [-PlatformFaultDomain <Int32>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
[-Confirm] [<CommonParameters>]
```

### DefaultParameterSet
Expand All @@ -47,7 +48,8 @@ New-AzVM [[-ResourceGroupName] <String>] [[-Location] <String>] [-EdgeZone <Stri
[-DataDiskDeleteOption <String>] [-EnableUltraSSD] [-ProximityPlacementGroupId <String>] [-HostId <String>]
[-VmssId <String>] [-Priority <String>] [-EvictionPolicy <String>] [-MaxPrice <Double>] [-EncryptionAtHost]
[-HostGroupId <String>] [-CapacityReservationGroupId <String>] [-UserData <String>]
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
[-PlatformFaultDomain <Int32>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
[<CommonParameters>]
```

## DESCRIPTION
Expand Down Expand Up @@ -640,6 +642,21 @@ Accept pipeline input: False
Accept wildcard characters: False
```

### -PlatformFaultDomain
Specifies the fault domain of the virtual machine.

```yaml
Type: System.Int32
Parameter Sets: SimpleParameterSet, DiskFileParameterSet
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False
```

### -Priority
The priority for the virtual machine. Only supported values are 'Regular', 'Spot' and 'Low'.
'Regular' is for regular virtual machine.
Expand Down
21 changes: 18 additions & 3 deletions src/Compute/Compute/help/New-AzVMConfig.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ New-AzVMConfig [-VMName] <String> [-VMSize] <String> [[-AvailabilitySetId] <Stri
[-Zone <String[]>] [-ProximityPlacementGroupId <String>] [-HostId <String>] [-VmssId <String>]
[-MaxPrice <Double>] [-EvictionPolicy <String>] [-Priority <String>] [-Tags <Hashtable>] [-EnableUltraSSD]
[-EncryptionAtHost] [-CapacityReservationGroupId <String>] [-UserData <String>]
[-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
[-PlatformFaultDomain <Int32>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
```

### ExplicitIdentityParameterSet
Expand All @@ -28,8 +28,8 @@ New-AzVMConfig [-VMName] <String> [-VMSize] <String> [[-AvailabilitySetId] <Stri
[-IdentityType] <ResourceIdentityType> [-IdentityId <String[]>] [-Zone <String[]>]
[-ProximityPlacementGroupId <String>] [-HostId <String>] [-VmssId <String>] [-MaxPrice <Double>]
[-EvictionPolicy <String>] [-Priority <String>] [-Tags <Hashtable>] [-EnableUltraSSD] [-EncryptionAtHost]
[-CapacityReservationGroupId <String>] [-UserData <String>] [-DefaultProfile <IAzureContextContainer>]
[<CommonParameters>]
[-CapacityReservationGroupId <String>] [-UserData <String>] [-PlatformFaultDomain <Int32>]
[-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
```

## DESCRIPTION
Expand Down Expand Up @@ -236,6 +236,21 @@ Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False
```

### -PlatformFaultDomain
Specifies the fault domain of the virtual machine.

```yaml
Type: System.Int32
Parameter Sets: (All)
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False
```

### -Priority
The priority for the virtual machine. Only supported values are 'Regular', 'Spot' and 'Low'.
'Regular' is for regular virtual machine.
Expand Down