Microsoft.Azure.Management.Websites SDK upgrade to 3.1.2 #16344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
requested changes
Nov 9, 2021
| @@ -0,0 +1,2 @@ | |||
| "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" | |||
| "Az.Websites","Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps.EditAzureWebAppBackupConfiguration","Edit-AzWebAppBackupConfiguration","0","3030","The generic type for 'property UserAssignedIdentities' has been changed from 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.ManagedServiceIdentityUserAssignedIdentitiesValue]' to 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.UserAssignedIdentity]'. ","Change the generic type for 'property UserAssignedIdentities' back to 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.ManagedServiceIdentityUserAssignedIdentitiesValue]'." | |||
There was a problem hiding this comment.
Instead of suppressing every breaking change, we should consider how it's gonna affect our customers; is there a way to mitigate?
There was a problem hiding this comment.
Is this breaking change what you would expect? If so, please fill in the following table, so that we can compose a migration guide for our customer:
| cmdlet | breaking change | old usage | new usage |
|---|
There was a problem hiding this comment.
<style>
</style>
| cmdlet | breaking change | old usage | new usage |
|---|---|---|---|
| Edit-AzWebAppBackupConfiguration | The generic type for 'property UserAssignedIdentities' has been changed from 'System.Collections.Generic.IDictionary2[System.String,Microsoft.Azure.Management.WebSites.Models.ManagedServiceIdentityUserAssignedIdentitiesValue]' to 'System.Collections.Generic.IDictionary2[System.String,Microsoft.Azure.Management.WebSites.Models.UserAssignedIdentity]'. |
Edit-AzWebAppBackupConfiguration -FrequencyInterval -FrequencyUnit -KeepAtLeastOneBackup -Name IpRule -ResourceGroupName MyResourceGroup -RetentionPeriodInDays -StartTime 2016-11-30T22:00:00Z -StorageAccountUrl 'https://storageaccount.file.core.windows.net' | No change in customer usage. Same as old. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Kotasudhakarreddy
added this to the
Nov 2021 (2021-12-07) ❗ Breaking change release ❗ milestone
|
@isra-fel - except the build fail please review for rest of the tings. |
isra-fel
requested changes
Nov 29, 2021
| @@ -0,0 +1,2 @@ | |||
| "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" | |||
| "Az.Websites","Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps.EditAzureWebAppBackupConfiguration","Edit-AzWebAppBackupConfiguration","0","3030","The generic type for 'property UserAssignedIdentities' has been changed from 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.ManagedServiceIdentityUserAssignedIdentitiesValue]' to 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.UserAssignedIdentity]'. ","Change the generic type for 'property UserAssignedIdentities' back to 'System.Collections.Generic.IDictionary`2[System.String,Microsoft.Azure.Management.WebSites.Models.ManagedServiceIdentityUserAssignedIdentitiesValue]'." | |||
There was a problem hiding this comment.
Is this breaking change what you would expect? If so, please fill in the following table, so that we can compose a migration guide for our customer:
| cmdlet | breaking change | old usage | new usage |
|---|
src/Websites/Websites/Cmdlets/Certificates/NewAzureWebAppCertificate.cs
Outdated
Show resolved
Hide resolved
|
@isra-fel Made the changes as suggested. Please take a review. |
|
Changed base branch to release-2021-12-07 as we have begun the release process |
|
Except for the tests, other changes look good to me |
…udhakarreddy/azure-powershell into DotNetSDK_upgrade_Oct_2021
Tests are passed. please review. |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
isra-fel
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.Azure.Management.Websites SDK upgrade to
3.1.2Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added