Fix FirewallRuleName wildcard filtering in Get-AzSqlServerFirewallRule #16237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thank you for your contribution regedit32! We will review the pull request and get back to you soon. |
|
Hi @regedit32 , please join Azure org in github |
BethanyZhou
previously approved these changes
Oct 28, 2021
BethanyZhou
approved these changes
Oct 28, 2021
|
Thanks @BethanyZhou , I'm joined now. |
BethanyZhou
added a commit
that referenced
this pull request
Oct 29, 2021
* Update ci config to add tools/GeneratedModuleList.txt to skip list (#16216) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Fix an issue in checking if we need to prompt survey. (#16232) * Fix FirewallRuleName wildcard filtering in Get-AzSqlServerFirewallRule (#16237) * Add Wildcard helper * Fix wildcard filtering in Get-AzSqlServerFirewallRule * Update src/Sql/Sql/ChangeLog.md Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * [Storage] Add example for move datalakegen2 item with Sas (#16256) * Update Invoke-AzVMRunCommand.md (#16000) * Update Invoke-AzVMRunCommand.md #15704 * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md * Update Invoke-AzVMRunCommand.md Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: Beisi Zhou <zazbs@qq.com> * Update notebook and spark job definition cmdlets to support folder path (#16269) -update change log -add example for specifying multi-level folder path -update FolderName to FolderPath as PowerShell Team suggested -update foldername description in help doc -resolve some comments in code review -update change log -add new parameter foldername Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: kceiw <mahuang@microsoft.com> Co-authored-by: Reggie Gibson <31147354+regedit32@users.noreply.github.com> Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: Micah McKittrick <32313503+mimckitt@users.noreply.github.com> Co-authored-by: YanjunGao <85206987+yanjungao718@users.noreply.github.com>
|
Thank you both for addressing this so quickly 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the wildcard filtering for FirewallRuleName when using Get-AzSqlServerFirewallRule as described in #16199. The SubResourceWildcardFilter method supported wildcards for properties like
NameorResourceGroupName, but not one likeFirewallRuleName. Created a wildcard filter helper for Sql to address the issue.Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added