Initial commit for the Websites commandlets for ARM #154

NaveenGoli · 2015-02-10T01:29:56Z

No description provided.

azuresdkci · 2015-02-10T01:29:56Z

Can one of the admins verify this patch?

azurecla · 2015-02-10T01:29:58Z

Hi @NaveenGoli, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (ngoli). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

amitapl · 2015-02-10T02:09:12Z

src/AzurePowershell.sln

@@ -161,7 +161,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.StreamAnalytics.Te
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Insights", "ResourceManager\Insights\Commands.Insights\Commands.Insights.csproj", "{DEA446A1-84E2-46CC-B780-EB4AFDE2460E}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Insights.Test", "ResourceManager\Insights\Commands.Insights.Test\Commands.Insights.Test.csproj", "{469F20E0-9D40-41AD-94C3-B47AD15A4C00}"


why did you remove this project?

amitapl · 2015-02-10T02:22:17Z

Is the file src/ResourceManager/Websites/Commands.Websites/MSSharedLibKey.snk required in the repo?

galiniliev · 2015-02-10T02:22:46Z

src/ResourceManager/Websites/Commands.Websites/Utilities/WebsitesClient.cs

+        }
+
+
+


extra new lines

ogail · 2015-02-10T17:55:59Z

@azuresdkci add to whitelist

NaveenGoli · 2015-02-11T03:00:42Z

I have incorporated all the feedback changes. please review..

amitapl · 2015-02-11T18:16:01Z

src/ResourceManager/Websites/Commands.Websites/Cmdlets/NewAzureWebsites.cs

+using Microsoft.WindowsAzure.Commands.Utilities.Common;
+using Microsoft.Azure.Commands.Websites.Utilities;
+
+


you have some extra \n throughout

amitapl · 2015-02-12T03:04:48Z

looks good

NaveenGoli · 2015-02-12T07:12:41Z

Will this be merged? AFAI can see, Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests has no relation to websites code changes.. please let me know what the next steps are..

matt-gibbs · 2015-02-12T08:00:26Z

Not until the tests are passing. The reason New-AzureResourceGroup is not being found will need to be investigated.

matt-gibbs · 2015-02-12T08:00:48Z

re-test this please.

NaveenGoli · 2015-02-13T01:42:17Z

its passing on my local machine..

Assemblies Run

C:\GitHUb\azure-powershell\src\ResourceManager\Sql\Commands.Sql.Test\bin\Debug\Microsoft.Azure.Commands.Sql.Test.dll

Summary

Tests run: 3 Skipped: 2, Run time: 57.330s

Skipped tests

Skipped
❢
Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests.TestDatabaseUpdatePolicyWithStorage

Skipped
❢
Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests.TestFailedDatabaseUpdatePolicyWithNoStorage

All tests

Click test class name to expand/collapse test details

57.070s
✔
Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests (3 tests)

… project to avoid the sql test failures due to module load issues.

NaveenGoli · 2015-02-24T01:25:15Z

when will this pull be taken in? I was under the impression it will happen today?

Initial commit for the Websites commandlets for ARM

yadavbdev · 2015-02-25T23:42:13Z

There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context?

NaveenGoli · 2015-02-25T23:59:38Z

+Mark

Sent from my Windows Phone

From: Yadav Bhattarai (Microsoft)mailto:notifications@github.com
Sent: ‎2/‎25/‎2015 3:42 PM
To: Azure/azure-powershellmailto:azure-powershell@noreply.github.com
Cc: Naveen Golimailto:ngoli@hotmail.com
Subject: Re: [azure-powershell] Initial commit for the Websites commandlets for ARM (#154)

There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context?

Reply to this email directly or view it on GitHub:
#154 (comment)

Removing E2ETest

.

azurecla added the cla-not-required label Feb 10, 2015

amitapl reviewed Feb 10, 2015
View reviewed changes

galiniliev reviewed Feb 10, 2015
View reviewed changes

src/ResourceManager/Websites/Commands.Websites/Utilities/WebsitesClient.cs

}

Copy link

galiniliev Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra new lines

NaveenGoli force-pushed the dev branch from 5359329 to f29d632 Compare February 10, 2015 03:19

amitapl reviewed Feb 11, 2015
View reviewed changes

Initial commit for the Websites commandlets for ARM

e0ed6f0

NaveenGoli force-pushed the dev branch from c2eb7ef to e0ed6f0 Compare February 12, 2015 03:03

NaveenGoli added 2 commits February 17, 2015 13:50

removing format.ps1xml file from processing

f607a6e

Per Marks suggestion added reference to websites project in resources…

3072a19

… project to avoid the sql test failures due to module load issues.

stankovski added a commit that referenced this pull request Feb 25, 2015

Merge pull request #154 from NaveenGoli/dev

df9a0ce

Initial commit for the Websites commandlets for ARM

stankovski merged commit df9a0ce into Azure:dev Feb 25, 2015

yadavbdev referenced this pull request Feb 26, 2015

Fix compilation error

b9345bf

markcowl pushed a commit that referenced this pull request Sep 25, 2015

Merge pull request #154 from MabOneSdk/pragrawadev1

1b43ca4

Removing E2ETest

AzureRT referenced this pull request in AzureRT/azure-powershell Oct 16, 2015

Merge pull request #154 from Azure/dev

6f2d28f

.

		using Microsoft.WindowsAzure.Commands.Utilities.Common;
		using Microsoft.Azure.Commands.Websites.Utilities;

Initial commit for the Websites commandlets for ARM #154

Initial commit for the Websites commandlets for ARM #154

Uh oh!

Conversation

NaveenGoli commented Feb 10, 2015

Uh oh!

azuresdkci commented Feb 10, 2015

Uh oh!

azurecla commented Feb 10, 2015

Uh oh!

amitapl Feb 10, 2015

Choose a reason for hiding this comment

Uh oh!

amitapl commented Feb 10, 2015

Uh oh!

galiniliev Feb 10, 2015

Choose a reason for hiding this comment

Uh oh!

ogail commented Feb 10, 2015

Uh oh!

NaveenGoli commented Feb 11, 2015

Uh oh!

amitapl Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

NaveenGoli Feb 12, 2015

Choose a reason for hiding this comment

Uh oh!

amitapl commented Feb 12, 2015

Uh oh!

NaveenGoli commented Feb 12, 2015

Uh oh!

matt-gibbs commented Feb 12, 2015

Uh oh!

matt-gibbs commented Feb 12, 2015

Uh oh!

NaveenGoli commented Feb 13, 2015

Uh oh!

NaveenGoli commented Feb 24, 2015

Uh oh!

yadavbdev commented Feb 25, 2015

Uh oh!

NaveenGoli commented Feb 25, 2015

Uh oh!

Uh oh!