Skip to content

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Feb 11, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@grizzlytheodore
Copy link
Contributor

@dingmeng-xue this PR is for removing all the ContainerServices (API deprecated) related code.

@grizzlytheodore
Copy link
Contributor

adding 'EncryptionatHost: ' parts are to avoid build errors. New property was added in to SecurityProfile property and needed to specify.

@VeryEarly VeryEarly self-assigned this Feb 20, 2021
@VeryEarly
Copy link
Collaborator

I suggest you to resolve all the CI failures for one of these two PRs:
#14186

and working on the other one (there are duplicates in these two PRs)

@Sandido Sandido marked this pull request as draft February 22, 2021 05:02
@msJinLei msJinLei added the needs-author-feedback More information is needed from author to address the issue. label May 24, 2021
@Sandido Sandido closed this Jun 22, 2021
@Sandido Sandido deleted the Sandido20201201Release branch June 22, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-author-feedback More information is needed from author to address the issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants