Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Get IKE Security Associations for VPN Site Link Connections #14182

Merged
merged 22 commits into from
Feb 22, 2021

Conversation

abhi7860
Copy link
Member

Description

Customers can now fetch IKE Security Associations for VPN Site Link Connections

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

<PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.5" />
<PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="3.1.0-preview.2" />
<PackageReference Include="Microsoft.Azure.Insights" Version="0.16.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="39.0.0" />
<PackageReference Include="Microsoft.Azure.Management.Compute" Version="43.0.0-preview" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might potentially have impact on other teams working on this branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Swagger was checked-in in the network-november-release. Until the official SDK is generated, the tests don't pass, right? I plan on reverting those files once that has been done if that's alright. Or I can revert it now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you recommend? @VeryEarly

Copy link
Contributor

@VeryEarly VeryEarly Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you recommend? @VeryEarly

the network SDK is fine, what I mean is the compute SDK.
It looks like a major version upgrade and it's possible that other test cases are not compatible with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway let's run the CI and see.

@VeryEarly VeryEarly self-assigned this Feb 11, 2021
@abhi7860 abhi7860 requested a review from VeryEarly February 11, 2021 08:02
@VeryEarly
Copy link
Contributor

Hi @abhi7860 ,

There are several other test.csproj need to be updated with the local feed SDK, please see below PR as reference:
https://github.com/Azure/azure-powershell/pull/13905/files

Copy link
Contributor

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are cred found in test, please suppress them all.

Abhishek Shah and others added 2 commits February 18, 2021 22:52
* Added Zone Redundancy for Recovery Service Vaults (Azure#13962)

* Corrected example command (Azure#13901)

* Corrected example command

The Get-AzRecoveryServicesBackupProtectableItem command in the example was incorrect.

* Updated the Example 1

$Container was using "MSSQL" for ContainerType which is an invalid option.
$Container was missing VaultId
$Item was missing WorkloadType

* Update Get-AzRecoveryServicesBackupProtectableItem.md

Added spacing between terminal and command

* [AppService] Register App Service Resources for Private Link Powershells (Azure#13967)

* Update ChangeLog.md

* Register App Service Resources for Private Link Powershells

* Update ChangeLog.md

* Update ChangeLog.md

* Only use supported commands for prediction request (Azure#13863)

* Only use supported commands for prediction request.

- We only request predictions for the last two commands. When the
  commands are not supported, we replace them with "start_of_snippet".
  The problem of that is when the user has inputted a few unsupported
  commands such as assignments, we'll start to request prediction for
  [ "start_of_snippet", "start_of_snippet" ]. That'll the same as
  resetting the prediction as the beginning of the session. While in
  fact there may be Az commands in the history.
- The change here is not to use those unsupported commands to request
  predictions. We'll skip the unsupported commands unless we don't have
  enough commands from history to use for the prediction.

* Incorporate PR feedback

* [Az.RecoveryServices.Backup] modifying policy validation limits as per backup service (Azure#14006)

* modifying policy validation limits as per backup service

* updated changelog

* Improve getting command ast and parse parameters (Azure#13864)

* Improve getting command ast and parse parameters.

- We use the RelatedAsts from PSReadLine to get the command AST as the
  user input. This is what our prediction will try to match.
- Now we can parse the parameter in the format of "-Name:Value".
- We don't parse  positioinal parameters yet.

* Incorporate PR feedback.

* Add test matrix for Az.Accounts (Azure#13760)

* add test matrix for Az.Accounts

* Update test-matrix-for-az-accounts.md

* Update test-matrix-for-az-accounts.md

* update to address comments

* update category description

* refine test auto tag

* refine test matrix

* refine document

* Documentation improvement to Az.StackHCI (Azure#13988)

* Fix example format of Register-AzStackHCI

* module description

* Update Register-AzStackHCI.md

* exit 0

* Support for Proximity placement group and Availability zone for Vmware to Azure and HyperV to Azure scenarios (Azure#14007)

* Support for Proximity placement group and Availability zone for Vmware to Azure and HyperV to Azure scenarios

* Updated changeLog to resolve conflicts�

* Updated changelog

* Resolving conflicts

* Addressed review comments

* Resolving conflict

* Resoving conflicts in changeLog.md file

* Fixed broken link to contribution guidelines (Azure#14009)

* Fixed broken link to contribution guidelines

I assume the correct link should be `https://opensource.microsoft.com/collaborate` like it was updated in other projects like [azure-sdk](Azure/azure-sdk-for-c#1101).

* Updated broken link in contributing.md

Co-authored-by: Damien Caro <dcaro@microsoft.com>

* Update error kind when context is incorrect (Azure#14013)

* Release Az.Migrate 2021-01-21 (Azure#13995) (Azure#14027)

* enable import EC key via byok (Azure#14002)

Co-authored-by: Yeming Liu <yeliu@microsoft.com>

* [HDInsight] Support compute isolation feature and return private ip address feature (Azure#14032)

* Support compute isolation feature and return private ip address feature

* Fix bad code style

Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>

* Update .gitignore - ignore all test results (Azure#14043)

* Webapp: Support for appservice ImportKeyVault Certificate (Azure#14037)

* #Commit1

* #Commit2

* #Commit3

* Cplat enablebursting (Azure#14038)

* bursting enabled

* update

* [Automation]Fix the issue of processing PSCustomObject (Azure#14045)

* Fix the issue of processing PSCustomObject.

* Add changelog

* Update ChangeLog.md

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* Log Analytics new parameters Group By ApplicationId and UserAgent (Azure#14015)

* data dog work, signed nuget packages

* nuget pkg from signed location .net

* using the package that released data dog functionality

* update nuget and disk objs

* back to 42 to avoid test failures

* v42

* Update RecoveryServices.Backup.Test.csproj

* Update RecoveryServices.SiteRecovery.Test.csproj

* Update SqlVirtualMachine.Test.csproj

* remove bad cmdlet to see if resolves CI errors

* Update LogAnalyticTests.ps1

Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

> > @Sandido
> > Compute test module uses storage via cmdlets defined in AzureRM.Storage.ps1. New-AzStorageContext cannot be recognized because it is not defined in AzureRM.Storage.ps1.
> > Could you try to modify your test and not to use these storage cmdlets?
> 
> @msJinLei , Without this cmdlet, the test does not function. I have commented out the test code, and made the test a LiveOnly test. The code can be uncommented to be run locally. I will see if the SDK team can add New-AzStorageContext to AzureRM.Storage.ps1 at a later date. We want this work merged by 2/1 so please consider this PR for merging.

OK

* Fix top value when top is not provided (Azure#14051)

* Fix top value when max is not provided

* Fix changelog.md error

* Update ChangeLog.md

Co-authored-by: Namrata Jagasia <najagasi@microsoft.com>
Co-authored-by: msJinLei <leijin@microsoft.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

* breaking change message (Azure#14050)

* Update WAF Sdk to support RequestBodyCheck and JSON exclussions (Azure#14044)

* Update WAF Sdk to support RequestBodyCheck and JSON exclussions

* Add check to test case

* Add sets

* Update ChangeLog.md

Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

* rename VMWare to VMware, and set confirmimpact to 'High' for remove-azvmwareprivatecloud (Azure#14031)

* rename VMWare to VMware

* Update Changelog.md

* Update Changelog.md

* fix changelog

* change name from virtual router to route server

* Fix predicate expression for server audit (Azure#14063)

* fix PredicateExpression for server audit policy

* re-record all audit tests to avoid regression

* updated ChangeLog.md

* Make build change

* Undo make build change

Co-authored-by: Oleg Sternberg <olsternb@microsoft.com>

* Add ExpressRoutePort MACsec SCI state  (Azure#13928)

* Migrate macsec changes from broken repo

* Move get service principal id into PS script.  Add documentation in PS test cript

* Update ChangeLog.md

* Add SciState to Get-AzExpressRoutePort help examples

* Add test record

* change name from virtual router to route server (Azure#14061)

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Update service principal warning (Azure#14064)

* Azure VMware Solution (Azure#14059)

* Add codeowner for policyInsights (Azure#14052)

We had a change go into our cmdlets from someone outside the service team.  Want to ensure future changes are reviewed by us,

* Enable Get-AzVM piping to Get-AzVMExtension cmdlet (Azure#14039)

* dev, test, changelog, help doc

* resourceId and switch

* id

* resourceId fix

Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

* Fix Microsoft.Azure.Management.ResourceManager dll conflict (Azure#14072)

* Upgrade common, implement getserviceclient credential, invoke listener to be cleared (Azure#14073)

* Using the latest version of autorest to generate code for 'costmanagement' (Azure#14048)

* Move CostManagement to master

* update the changelog

* update the changelog file

Co-authored-by: azurepowershell <azurepowershell@ms.com>

* [Storage] Upgrade XSCL and Azure.Core 1.8.1 (Azure#14058)

* Remove tools/VersionController/packages.config (Azure#14065)

* Webapp: [Documentation]Adding Linux property for New-AzAppServicePlan cmdlet (Azure#14078)

* #Commit1

* #Commit2

* #Commit3

* #13531Commit1

* Set-AzDataLakeGen2AclRecursive.md - Fix typo (directiry -> directory) (Azure#14082)

* Using the latest version of autorest to generate code for 'Databricks' (Azure#14049)

* Move Databricks to master

* update the changelog

* update the changelog file

Co-authored-by: azurepowershell <azurepowershell@ms.com>

* Add CloudError code into exception for tracking (Azure#14077)

* Update error kind when context is incorrect

* Add cloud error code into exception data

* Add changelog

* Improve error handling and bug fix (Azure#14033)

* Improve error handling and bug fix

* Change literal string to constant per change in Common assembly

* Fix build error

* Code refactoring

* add ACR repository operations (Azure#13946)

* add ACR repository operations

* add shouldprocess

* implement iazuresessioncomponentlistener

* add comments and exception

* fix cache impl

* resolve comments

* getlastlisted

* remove unused class

* remove unneeded changes

* fix null reference in PSAcrManifest and remove unused suppression

* Update ChangeLog.md

* fix Acr to ACR in help markdown

* fix output type for Get-AzContainerRegistryRepository

* polish changelog for upcoming release (Azure#14076)

* Polish changelog for az.accounts (Azure#14080)

* Update ChangeLog.md

* Update ChangeLog.md

* Create ChangeLog.md

Co-authored-by: Dingmeng Xue <dixue@microsoft.com>

* Update Az.Accounts help (Azure#14090)

* Added cmdlet Test-AzMySqlFlexibleServerConnect (Azure#14091)

* Revert module version (Azure#14098)

* Add cmdlet Test-AzPostgreSqlFlexibleServerConnect (Azure#14096)

* Add cmdlet Test-AzPostgreSqlFlexibleServerConnect

* Update ChangeLog.md

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Cover New-AzSqlElasticPool case for SQL maintenance (Azure#14102)

* Cover New-Pool case for maintenance

* Added test coverage

Co-authored-by: Dingmeng Xue <dixue@microsoft.com>

* Remove incorrect changelog (Azure#14099)

* Revert module version

* Remove incorrect changelog

* add cmdlets Get/Start/convert-SynapseVulnerabilityAssessmentScan (Azure#13690)

* SynapseVulnerabilityAssessmentScan

* refine name

* refine function

* fix problem for StartAzureSynapseSqlPoolVulnerabilityAssessmentScan not work

* some draft codes

* resolve confilct 2

* removce strange sign

* format code

* refine function

* add test

* add help doc

* code refine

* format refine

* update Az.Synapse.psd1

* add test json

* refinde document

* improve help examples

* added test json

* added test json 2

* improved test

* add tests to credscansuppression

* Get-AzSynapseSqlPoolGeoBackup and Get-AzSynapseDroppedSqlPool. (Azure#13621)

* GetAzureSynapseSqlPoolGeoBackup

* refine function and constant

* add help

* GetAzureSynapseSqlDeletedDatabaseBackup

* refine backup function

* refine doc

* add Getazuresynapsesqldeleteddatabasebackup

* refined help doc

* refine function

* resolve id name type not found in output problem

* add test

* update command name

* resolve some comments

* resovle function problem

* test improvement

* add wildcard

* rename help doc

* add resourceid

* Update ChangeLog.md

Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

* Type fox: changed SshKeyVaule to SshKeyValue (Azure#14087)

* Examples used New-AzAks which is legacy cmdlet and the alias for New-AzAksCluster. Changed examples to use New-AzAksCluster which is the cmdlet this documentation page targets. (Azure#14088)

Co-authored-by: erich-wang <eriwan@microsoft.com>

* Fixed a typo in the cmdlet (Azure#14112)

* Add legal term and parameter -AcceptEULA to 'New-AzVMwarePrivateCloud' (Azure#14111)

* Move VMware to master

* update changelog

* Update Changelog.md

* Update New-AzVMwarePrivateCloud.ps1

* Update New-AzVMwarePrivateCloud.md

* Update New-AzVMwarePrivateCloud.ps1

Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: Dingmeng Xue <dixue@microsoft.com>

* Revert "Pass principal type during role assignment put operations" (Azure#14122)

* Revert "Pass principal type during role assignment put operations (Azure#13590)"

This reverts commit 3d473e4.

* changelog

* update changelog

Co-authored-by: Daniel Orozco <64658732+dagoroz@users.noreply.github.com>
Co-authored-by: Daniel Orozco <Daniel.Orozco@microsoft.com>

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service (Azure#14128) (Azure#14131)

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service

* Update in changeLog

* Update in help file

* Minor fix in help file

* Added test cases

* NIT fixes for spaces

* Addressed review comments

Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>

* Added support for -QueryString parameters to cmdlets hitting /validate API and Fixed issues with dynamic parameters (Azure#14132)

* QuerySTring support for validate cmdlets

* Refactor querystring; Fix issues with dynamic parameters

* Updated changelog and help files

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service (Azure#14128)

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service

* Update in changeLog

* Update in help file

* Minor fix in help file

* Added test cases

* NIT fixes for spaces

* Addressed review comments

Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>

* release-2021-02-09 (Azure#14137)

* release-2021-02-09

* Update ChangeLog.md

* switch param best practice (Azure#14142)

* add local parameter map saving to a local file (Azure#14018) (Azure#14140)

* add local parameter map saving to a local file

* fix local parameter map saving

* revere serviceUri change in AzPredictorSettings

Co-authored-by: yemohyle <73853907+yemohyle@users.noreply.github.com>

* Remove culture from help markdown files (Azure#14047)

* update MarkDwon file to remove specified language

* update the "HelpGeneration" file to fix static analysis issue

* Update the ‘Az.VMware.md’ file

* update the "HelpGeneration" files

* update markdown file to fix online url issue for azsynapse

* update markdown file for Synaps

* Test-AzMySqlFlexibleServerConnect.md

* Update Test-AzPostgreSqlFlexibleServerConnect.md

Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>

* Optimize for CI filter. (Azure#13994)

* Optimize for CI filter.

* Add support for TargetModule

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* [Tools] Use type fullname to avoid issue from class renaming. (Azure#14147)

* Optimize for CI filter.

* Add support for TargetModule

* Avoid the issue caused by renaming class.

* Avoid the issue caused by renaming class.

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* Fix example doc syntax (Azure#14146)

* [Tools] Fix the issue of different name of module and folder when run CI pipeline (Azure#14151)

* Optimize for CI filter.

* Add support for TargetModule

* Avoid the issue caused by renaming class.

* Avoid the issue caused by renaming class.

* Fix the issue of different name of module and folder

* Fix the issue of different name of module and folder

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* [DataFactory]Upgrade sdk version to 4.14.0 (Azure#14149)

* [DataFactory]Upgrade sdk version to 4.14.0

* revert

* Revert "revert"

This reverts commit aa7f924.

* Azure Automation documentation update for Get-AzAutomationWebhook and New-AzAutomationSourceControl (Azure#14154)

* Updating documentation

* Adding new line and adding bold emphasis

* Small spelling, formatting changes (Azure#14155)

'objecy' jumped out at me, so I figured I'd see if there's anything else needs changing to make this look better.
Question: In other functions, SubscriptionId is a "String" type - here it is listed as a "String[]" type - is this correct?

* Update Set-AzNetworkSecurityRuleConfig.md (Azure#14176)

* Added an additional cmdline to the example which applies the changes to the load balancer (Azure#14185)

When running the PowerShell example, the changes will not be applied to the load balancer unless you perform an additional Set-AzLoadBalancer step.

* Add cmdlet to enable/disable az predictor (Azure#14188)

* Add cmdlet.

* Modify the parmaeter values.

* Fixed issues with TemplateSpec deployments in New-AzTenantDeployment … (Azure#14179)

* Fixed issues with TemplateSpec deployments in New-AzTenantDeployment and New-AzManagementGroupDeployment

* Review fixes

* Modified and re-recorded Test-NewMGDeploymentFromTemplateSpec

* Acr fix (Azure#14177) (Azure#14189)

* fix docker push issue: use refresh token to login

* changelog

* OOB release for Az.ContainerReigstry

* resolve comments

* Blueprint: Unregister API delegating handler (Azure#14200)

* Update blueprint client to unregister api handler

* Update change log

* Use initial client design where we create seperate clients based on whether delegating handler is used. This works better with piping scenarios

* New and set artifact cmdlets don't require bp client with $expand handler

* Clean white space

* Clean up more white space

* Fix the issue that PR changed files list is empty (Azure#14202)

* Fix the issue that PR changed files list is empty

* Fix the issue that PR changed files list is empty

Co-authored-by: wyunchi <yunwang@microsoft.com>

* update parameter descriptions: -CustomData for Set-AzVMOperatingSystem and -LicenseType for New-AzVM (Azure#14210)

* update md files

* Update Set-AzVMOperatingSystem.md

* Update Set-AzVMOperatingSystem.md

* Update New-AzVM.md

* Update the cmdlet parameters according to feedback. (Azure#14217)

* [DPS] Add attestation mechanism updates to device enrollment and enrollment group commands (Azure#14219)

* Added attestation mechanism updates to device enrollment and enrollment group commands

* Updated changelog

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Add prompt for usage and survey (Azure#13965)

* Add prompt for usage and survey.

* Condition the survey and correlate survey and telemetry.

- Check if the user has used the module in the past 30 days and whether
  the user uses at least 3 times. If so, prompt the survey.
- Create a survey id based on user id and use it to associate the survey
  and the telemetry.
- Add a field in the telemetry to check if the telemetry data is from an
  internal user.

* Wrap the intercept script in the script to process.

* Update the link and message color.

* Update the survey prompt UI.

* Updated module description

* Revert the version and add copyright.

* Incorporate feedback.

* Incorporate feedback.

* Improve the comment.

* Use a new flag to ignore null value in json serialization.

* Remove the prompt about psreadlineoption.

- It's replaced with cmdlets.

Co-authored-by: Damien Caro <dcaro@microsoft.com>

* [Tools] Fix the issue of CI Pipeline (Azure#14222)

* Fix the issue that cannot fine valid module for Generated module in CI pipeline

* Fix the issue that Target module fails

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* Cosmos DB: Update to 2.0.0 and Add support for NetworkAclBypass in Account (Azure#14211)

* Make changes for Network Acl Bypass

* Add help file updates

* Changes with enum not as string

* rerun tests

* Remove extra line

* rerun gremlin test with updated

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Fixed invalid ts deployment error message (Azure#14236)

* Fixed invalid ts deployment error message and added support for -TemplateParameterObject in TS deployments

* Update help files for new parameter set

* review fixes

* [AzRecoveryServices.Backup] Adding null check for target storage account (Azure#13681)

* Adding null check for target storage account

* fixing the operations delay

* re-recorded failed tests

* Add support for Python 3 Runbook Type (Azure#14226)

* Add support for Python 3 Runbook Type

* Update change.log

* Updated markdown help files

* Update ChangeLog.md

Co-authored-by: Mahak Jain <mahja@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Update Add-AzLoadBalancerInboundNatPoolConfig.md (Azure#14231)

with out using the Set-AzLoadBalancer after line 42 the natpool config will not be updated to the LB and the example would be incomplete.

* Log Analytics .md files updates (Azure#14203)

* desc update and results

* changelog

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
Co-authored-by: Sebastian Olsen <30187002+Spacebjorn@users.noreply.github.com>
Co-authored-by: jiansong-msft <77516279+jiansong-msft@users.noreply.github.com>
Co-authored-by: kceiw <hellomao@outlook.com>
Co-authored-by: erich-wang <eriwan@microsoft.com>
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: vidyadharijami <57709079+vidyadharijami@users.noreply.github.com>
Co-authored-by: Alexander Schmidt <32797407+devdeer-alex@users.noreply.github.com>
Co-authored-by: Damien Caro <dcaro@microsoft.com>
Co-authored-by: Dingmeng Xue <dixue@microsoft.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Co-authored-by: Yeming Liu <yeliu@microsoft.com>
Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: ThejaChoudary <57453616+ThejaChoudary@users.noreply.github.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: najagasi <49212852+najagasi@users.noreply.github.com>
Co-authored-by: Namrata Jagasia <najagasi@microsoft.com>
Co-authored-by: msJinLei <leijin@microsoft.com>
Co-authored-by: digavino <48699384+digavino@users.noreply.github.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: Oleza1972 <63361762+Oleza1972@users.noreply.github.com>
Co-authored-by: Oleg Sternberg <olsternb@microsoft.com>
Co-authored-by: francescanarea <francesca@Narea.com>
Co-authored-by: Robert Lyon <35980532+rolyon@users.noreply.github.com>
Co-authored-by: Cameron Taggart <cameron.taggart@gmail.com>
Co-authored-by: Chris Eggert <pilor@users.noreply.github.com>
Co-authored-by: Youri970410 <62531040+Youri970410@users.noreply.github.com>
Co-authored-by: azurepowershell <azurepowershell@ms.com>
Co-authored-by: Wei Wei <weiwei@microsoft.com>
Co-authored-by: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
Co-authored-by: Roman Khotsyn <rokhot@microsoft.com>
Co-authored-by: zesluo <zesluo@microsoft.com>
Co-authored-by: Jan David Narkiewicz <jdnark@gmail.com>
Co-authored-by: Martin Ehrnst <martin@ehrnst.no>
Co-authored-by: Daniel Orozco <64658732+dagoroz@users.noreply.github.com>
Co-authored-by: Daniel Orozco <Daniel.Orozco@microsoft.com>
Co-authored-by: Gokul Premraj <gopremra@microsoft.com>
Co-authored-by: yemohyle <73853907+yemohyle@users.noreply.github.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com>
Co-authored-by: Shivam Tyagi <56990792+shivamT95-msft@users.noreply.github.com>
Co-authored-by: alunmj <alun@texis.com>
Co-authored-by: webguynj <webguynj@users.noreply.github.com>
Co-authored-by: Yannick Dils <62245199+yannickdils@users.noreply.github.com>
Co-authored-by: Filiz Topatan <fitopata@microsoft.com>
Co-authored-by: Ryan K <ryan.k@outlook.com>
Co-authored-by: kristynhamasaki <68716650+kristynhamasaki@users.noreply.github.com>
Co-authored-by: mahakjain314 <50352900+mahakjain314@users.noreply.github.com>
Co-authored-by: Mahak Jain <mahja@microsoft.com>
Co-authored-by: chakra146 <61271207+chakra146@users.noreply.github.com>
@VeryEarly VeryEarly merged commit 5816106 into Azure:network-november Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants