Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Cognitive Search][Management SDK] Update Az.Search to use latest SDK version of management SDK #13904

Merged
merged 15 commits into from
Jan 15, 2021
Merged

[Azure Cognitive Search][Management SDK] Update Az.Search to use latest SDK version of management SDK #13904

merged 15 commits into from
Jan 15, 2021

Conversation

arv100kri
Copy link
Member

@arv100kri arv100kri commented Jan 8, 2021 •
edited
Loading

Description

Pulled in the latest .NET SDK for the Microsoft.Azure.Search.Management package and updated the Az.Powershell module to utilize all the latest features introduced. The following are the relevant changes:

  • Added new properties (IpRules, Identity, PrivateEndpointConnections and SharedPrivateLinkResources) to search service module and relevant cmdlets
  • Added ability to manage shared private link resources (and get list of supported private link resources)
  • Added ability to manage private endpoint connections

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@arv100kri arv100kri force-pushed the arv100kri/sdk-update branch 2 times, most recently from 52de0bf to 602bcf5 Compare January 11, 2021 19:41
Arvind Krishnaa Jagannathan added 14 commits January 11, 2021 19:00
Update search mgmt sdk
de5bfb4
Fix breaking change
e44190a
Add all the new models from SDK update
f3412b4 
* IP rules
* Identity
* Public network access
* Private endpoint connections
* Shared private link resources
Few more straggler branding changes
97b56c2
Add cmdlets for new features
d493b52 
* Private endpoint connections
* Private link resources
* Shared private link resources
Export cmdlets to psd1 and generate mardown + update documentation
0b1d047
Finish off tests
394a626
Update session records
fde1989
Add object pipeline parameters and corresponding documentation
dc58705
Add tests for the new parmeters and remove hardcoded resource id and
8f4c53a 
locations
Add session records
b7c71aa
Incorporate changes to fix static analysis errors
e8f35fe
Re-arrange order of imports
b17b210
Add storage.management csproj
2af59f6
@arv100kri arv100kri force-pushed the arv100kri/sdk-update branch from 602bcf5 to 2af59f6 Compare January 12, 2021 03:02
@arv100kri arv100kri force-pushed the arv100kri/sdk-update branch from 82cae1a to 0966741 Compare January 14, 2021 19:58
@arv100kri arv100kri marked this pull request as ready for review January 14, 2021 19:59
@msJinLei msJinLei self-requested a review January 15, 2021 07:54
@msJinLei msJinLei merged commit d9332a0 into Azure:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msJinLei msJinLei msJinLei approved these changes

@jqhuangonearth jqhuangonearth Awaiting requested review from jqhuangonearth

@tjacobhi tjacobhi Awaiting requested review from tjacobhi

@abhi1509 abhi1509 Awaiting requested review from abhi1509

@dereklegenzoff dereklegenzoff Awaiting requested review from dereklegenzoff

@isra-fel isra-fel Awaiting requested review from isra-fel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arv100kri @msJinLei